Skip to content

Commit

Permalink
rename conf key
Browse files Browse the repository at this point in the history
  • Loading branch information
@lsm1
lsm1 committed Nov 9, 2023
1 parent 7eca9e8 commit 5dd3fb9
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion docs/configuration/settings.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,9 @@ You can configure the Kyuubi properties in `$KYUUBI_HOME/conf/kyuubi-defaults.co
| kyuubi.engine.jdbc.connection.provider | <undefined> | The connection provider is used for getting a connection from the server | string | 1.6.0 |
| kyuubi.engine.jdbc.connection.url | <undefined> | The server url that engine will connect to | string | 1.6.0 |
| kyuubi.engine.jdbc.connection.user | <undefined> | The user is used for connecting to server | string | 1.6.0 |
| kyuubi.engine.jdbc.default.fetch.size | 1000 | The default fetch size of JDBC engine | int | 1.9.0 |
| kyuubi.engine.jdbc.driver.class | <undefined> | The driver class for JDBC engine connection | string | 1.6.0 |
| kyuubi.engine.jdbc.extra.classpath | <undefined> | The extra classpath for the JDBC query engine, for configuring the location of the JDBC driver and etc. | string | 1.6.0 |
| kyuubi.engine.jdbc.fetch.size | 1000 | The default fetch size of JDBC engine | int | 1.9.0 |
| kyuubi.engine.jdbc.initialize.sql | SELECT 1 | SemiColon-separated list of SQL statements to be initialized in the newly created engine before queries. i.e. use `SELECT 1` to eagerly active JDBCClient. | seq | 1.8.0 |
| kyuubi.engine.jdbc.java.options | <undefined> | The extra Java options for the JDBC query engine | string | 1.6.0 |
| kyuubi.engine.jdbc.memory | 1g | The heap memory for the JDBC query engine | string | 1.6.0 |
Expand Down
4 changes: 2 additions & 2 deletions ...kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/dialect/JdbcDialect.scala
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import java.util

import org.apache.kyuubi.{KyuubiException, KyuubiSQLException, Logging}
import org.apache.kyuubi.config.KyuubiConf
import org.apache.kyuubi.config.KyuubiConf.{ENGINE_JDBC_CONNECTION_URL, ENGINE_JDBC_DEFAULT_FETCH_SIZE, ENGINE_JDBC_SHORT_NAME}
import org.apache.kyuubi.config.KyuubiConf.{ENGINE_JDBC_CONNECTION_URL, ENGINE_JDBC_FETCH_SIZE, ENGINE_JDBC_SHORT_NAME}
import org.apache.kyuubi.engine.jdbc.dialect.JdbcDialects.defaultFetchSize
import org.apache.kyuubi.engine.jdbc.schema.{RowSetHelper, SchemaHelper}
import org.apache.kyuubi.engine.jdbc.util.SupportServiceLoader
Expand Down Expand Up @@ -88,7 +88,7 @@ object JdbcDialects extends Logging {

var defaultFetchSize: Int = 0
def get(conf: KyuubiConf): JdbcDialect = {
defaultFetchSize = conf.get(ENGINE_JDBC_DEFAULT_FETCH_SIZE)
defaultFetchSize = conf.get(ENGINE_JDBC_FETCH_SIZE)
val shortName: String = conf.get(ENGINE_JDBC_SHORT_NAME).getOrElse {
val url = conf.get(ENGINE_JDBC_CONNECTION_URL).get
assert(url.length > 5 && url.substring(5).contains(":"))
Expand Down
4 changes: 2 additions & 2 deletions kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2808,8 +2808,8 @@ object KyuubiConf {
.toSequence(";")
.createWithDefault(Nil)

val ENGINE_JDBC_DEFAULT_FETCH_SIZE: ConfigEntry[Int] =
buildConf("kyuubi.engine.jdbc.default.fetch.size")
val ENGINE_JDBC_FETCH_SIZE: ConfigEntry[Int] =
buildConf("kyuubi.engine.jdbc.fetch.size")
.doc("The default fetch size of JDBC engine")
.version("1.9.0")
.intConf
Expand Down

0 comments on commit 5dd3fb9

Please sign in to comment.