Skip to content

Commit

Permalink
fix code
Browse files Browse the repository at this point in the history
  • Loading branch information
wangjunbo committed Jan 16, 2024
1 parent 9fcc2c6 commit cca773a
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -339,10 +339,10 @@ private[kyuubi] class EngineRef(

def getServiceNodes(
discoveryClient: DiscoveryClient,
hostPort: (String, Int)): Seq[ServiceNodeInfo] = {
hostPort: (String, Int)): Option[ServiceNodeInfo] = {
tryWithLock(discoveryClient) {
val serviceNodes = discoveryClient.getServiceNodesInfo(engineSpace)
serviceNodes.filter { sn => (sn.host, sn.port) == hostPort }
serviceNodes.filter { sn => (sn.host, sn.port) == hostPort }.headOption
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class KyuubiSessionImpl(
engineLastAlive = System.currentTimeMillis()
}

def listZkEngineNodes: Seq[ServiceNodeInfo] = {
def getEngineNode: Option[ServiceNodeInfo] = {
withDiscoveryClient(sessionConf) { discoveryClient =>
engine.getServiceNodes(discoveryClient, _client.engineHostPort)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,18 +35,22 @@ import org.apache.kyuubi.sql.schema.{Column, Row, Schema}
case class DescribeEngine() extends RunnableCommand {

override def run(kyuubiSession: KyuubiSession): Unit = {
val rows = Seq(kyuubiSession.asInstanceOf[KyuubiSessionImpl]).flatMap { session =>
val rows = Seq(kyuubiSession.asInstanceOf[KyuubiSessionImpl]).map { session =>
lazy val client = session.client
session.listZkEngineNodes.map { nodeInfo =>
val values = new ListBuffer[String]()
values += client.engineId.getOrElse("")
values += client.engineName.getOrElse("")
values += client.engineUrl.getOrElse("")
values += s"${nodeInfo.host}:${nodeInfo.port}"
values += nodeInfo.version.getOrElse("")
values += nodeInfo.attributes.filter(_._1.contains("memory")).mkString(";")
Row(values.toList)
val values = new ListBuffer[String]()
values += client.engineId.getOrElse("")
values += client.engineName.getOrElse("")
values += client.engineUrl.getOrElse("")
session.getEngineNode match {
case Some(nodeInfo) =>
values += s"${nodeInfo.host}:${nodeInfo.port}"
values += nodeInfo.version.getOrElse("")
values += nodeInfo.attributes.mkString(",")
case None =>
values += ("", "", "")
}

Row(values.toList)
}
iter = new IterableFetchIterator(rows)
}
Expand Down

0 comments on commit cca773a

Please sign in to comment.