Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK][TRIVIAL] Correct the parameter name of fetching op log in RESTful API #5599

Closed
2 of 3 tasks
pan3793 opened this issue Nov 1, 2023 · 3 comments
Closed
2 of 3 tasks

[TASK][TRIVIAL] Correct the parameter name of fetching op log in RESTful API #5599

pan3793 opened this issue Nov 1, 2023 · 3 comments
Assignees
@GianlucaPrincipini
Labels
good first issue beginner skills required hacktoberfest

Comments

@pan3793
Copy link
Member

pan3793 commented Nov 1, 2023

Code of Conduct

Search before creating

  • I have searched in the task list and found no similar tasks.

Mentor

  • I have sufficient knowledge and experience of this task, and I volunteer to be the mentor of this task to guide contributors to complete the task.

Skill requirements

  • English

Background and Goals

https://kyuubi.readthedocs.io/en/master/client/rest/rest_api.html

image

Implementation steps

correct the word

Additional context

No response
@pan3793 pan3793 added the good first issue beginner skills required label Nov 1, 2023
@laglangyue
Copy link

I want work for this.

@pan3793
Copy link
Member Author

pan3793 commented Nov 3, 2023

@laglangyue thanks, assigned. also, there is some information for new contributors #5357

@GianlucaPrincipini GianlucaPrincipini mentioned this issue Nov 11, 2023
Closed
@GianlucaPrincipini
Copy link
Contributor

GianlucaPrincipini commented Nov 11, 2023 •
edited
Loading

Hi @pan3793 , I've created pull request #5673 to solve this issue.

pan3793 pushed a commit that referenced this issue Nov 13, 2023
@GianlucaPrincipini @pan3793
[KYUUBI #5599] Correct the parameter name of fetching op log in RESTf…
8d0758b 
…ul API

### _Why are the changes needed?_

It corrects the fetching op log Rest API documentation to match request parameter case in code, solving issue #5599

### _How was this patch tested?_
No tests needed.

### _Was this patch authored or co-authored using generative AI tooling?_

No AI tool has been used for this patch.

Closes #5673 from GianlucaPrincipini/fix-fetching-op-log-param-doc.

Closes #5599

f134af0 [GianlucaPrincipini] Change maxRows "param" to "maxrows" in documentation

Authored-by: GianlucaPrincipini <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit 4be584c)
Signed-off-by: Cheng Pan <[email protected]>
pan3793 pushed a commit that referenced this issue Nov 13, 2023
@GianlucaPrincipini @pan3793
[KYUUBI #5599] Correct the parameter name of fetching op log in RESTf…
e73ea0b 
…ul API

### _Why are the changes needed?_

It corrects the fetching op log Rest API documentation to match request parameter case in code, solving issue #5599

### _How was this patch tested?_
No tests needed.

### _Was this patch authored or co-authored using generative AI tooling?_

No AI tool has been used for this patch.

Closes #5673 from GianlucaPrincipini/fix-fetching-op-log-param-doc.

Closes #5599

f134af0 [GianlucaPrincipini] Change maxRows "param" to "maxrows" in documentation

Authored-by: GianlucaPrincipini <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit 4be584c)
Signed-off-by: Cheng Pan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GianlucaPrincipini GianlucaPrincipini

Labels
good first issue beginner skills required hacktoberfest
Projects
No open projects
2023 Kyuubi Code Contribution Program
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GianlucaPrincipini @pan3793 @laglangyue