[KYUUBI #5599] Correct the parameter name of fetching op log in RESTful API #5673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
bowenliang123
approved these changes
Nov 13, 2023
Codecov Report
@@ Coverage Diff @@
## master #5673 +/- ##
============================================
- Coverage 61.47% 61.38% -0.10%
Complexity 23 23
============================================
Files 603 603
Lines 35644 35644
Branches 4875 4875
============================================
- Hits 21913 21880 -33
- Misses 11358 11387 +29
- Partials 2373 2377 +4 see 15 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
yaooqinn
approved these changes
Nov 13, 2023
pan3793
pushed a commit
that referenced
this pull request
Nov 13, 2023
…ul API ### _Why are the changes needed?_ It corrects the fetching op log Rest API documentation to match request parameter case in code, solving issue #5599 ### _How was this patch tested?_ No tests needed. ### _Was this patch authored or co-authored using generative AI tooling?_ No AI tool has been used for this patch. Closes #5673 from GianlucaPrincipini/fix-fetching-op-log-param-doc. Closes #5599 f134af0 [GianlucaPrincipini] Change maxRows "param" to "maxrows" in documentation Authored-by: GianlucaPrincipini <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 4be584c) Signed-off-by: Cheng Pan <[email protected]>
pan3793
pushed a commit
that referenced
this pull request
Nov 13, 2023
…ul API ### _Why are the changes needed?_ It corrects the fetching op log Rest API documentation to match request parameter case in code, solving issue #5599 ### _How was this patch tested?_ No tests needed. ### _Was this patch authored or co-authored using generative AI tooling?_ No AI tool has been used for this patch. Closes #5673 from GianlucaPrincipini/fix-fetching-op-log-param-doc. Closes #5599 f134af0 [GianlucaPrincipini] Change maxRows "param" to "maxrows" in documentation Authored-by: GianlucaPrincipini <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 4be584c) Signed-off-by: Cheng Pan <[email protected]>
|
Thanks, merged to master(1.9.0)/branch-1.8(1.8.1)/branch-1.7(1.7.4) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
It corrects the fetching op log Rest API documentation to match request parameter case in code, solving issue #5599
How was this patch tested?
No tests needed.
Was this patch authored or co-authored using generative AI tooling?
No AI tool has been used for this patch.