[KYUUBI #5452][AUTHZ] Support Compaction table commands for Hudi #5454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngersZhuuuu
commented
Oct 18, 2023
|
|
||
| val CompactionHoodiePathCommand = { | ||
| val cmd = "org.apache.spark.sql.hudi.command.CompactionHoodiePathCommand" | ||
| TableCommandSpec(cmd, Seq.empty, CREATETABLE) |
There was a problem hiding this comment.
For path-related commands, we just ignore or handle them in another way? Is there any example? cc @yaooqinn @bowenliang123
There was a problem hiding this comment.
Maybe ignoring path based table first? There's another issue for path-based table #5368. We can align the processing way there.
There was a problem hiding this comment.
Maybe ignoring path based table first? There's another issue for path-based table #5368. We can align the processing way there.
Yea, will remain a sub task for compaction path
AngersZhuuuu
changed the title
bowenliang123
approved these changes
Oct 18, 2023
...yuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/gen/HudiCommands.scala
Outdated
Show resolved
Hide resolved
...scala/org/apache/kyuubi/plugin/spark/authz/ranger/HudiCatalogRangerSparkExtensionSuite.scala
Outdated
Show resolved
Hide resolved
bowenliang123
changed the title
|
Thanks, merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
To close #5452
Support Compaction table/path related command. The SQL grammar is https://github.com/apache/hudi/blob/release-0.14.0/hudi-spark-datasource/hudi-spark/src/main/antlr4/org/apache/hudi/spark/sql/parser/HoodieSqlCommon.g4
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Was this patch authored or co-authored using generative AI tooling?
No