-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AUTHZ] Authz shaded include the transitive jackson libs #5496
Conversation
I did a quick check on the shaded jar, and found the following issues:
|
Codecov Report
@@ Coverage Diff @@
## master #5496 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 588 588
Lines 33480 33480
Branches 4405 4405
======================================
Misses 33480 33480 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BTW, jna seems to be the dep of scala 2.13 |
LGPL2.1 comes from
jna looks like come from ranger |
I mean apache/spark#43008 (comment) |
Thanks for the information. It looks like we need to provide the scala-2.13 profile, which requires exclude jna. For the scala 2.13 profile, maybe the jna version of ranger is different from the jna version of scala 2.13, but I can't think of a good way to solve it, because jna cannot shade. |
@yikf I suppose we can use the jna provided in Spark, then let's excluding jna in scala-2.13 profile |
<artifactId>maven-shade-plugin</artifactId> | ||
<configuration> | ||
<artifactSet> | ||
<excludes> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you tested it? what's the behavior when both includes
and excludes
are present?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, merged to master |
Why are the changes needed?
As description #5427 (comment). This PR aims to:
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Was this patch authored or co-authored using generative AI tooling?
No