[KYUUBI #5373] Engine adaptive pool size #5662
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind:documentation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5662 +/- ##
============================================
- Coverage 58.49% 58.32% -0.17%
Complexity 24 24
============================================
Files 653 653
Lines 39865 39954 +89
Branches 5481 5492 +11
============================================
- Hits 23319 23305 -14
- Misses 14055 14149 +94
- Partials 2491 2500 +9 ☔ View full report in Codecov by Sentry. |
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala
Outdated
Show resolved
Hide resolved
...s/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala
Outdated
Show resolved
Hide resolved
...s/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala
Outdated
Show resolved
Hide resolved
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Nov 21, 2023
| client.create(metricsSpace, "PERSISTENT") | ||
| } | ||
| client.setData( | ||
| s"/metrics$engineSpace", |
There was a problem hiding this comment.
is it feasible to append the "load" value in engine's info zonde, and update in place?
if not, and decide to use a new path, we should consider deleting it after engine dead
@yaooqinn how do you think of this path to store engine metrics?
lsm1
force-pushed
the
branch-kyuubi-5373
branch
from
e339ddf to
f01d130
Compare
lsm1
force-pushed
the
branch-kyuubi-5373
branch
2 times, most recently
from
af19ce0 to
60852c0
Compare
cxzl25
reviewed
Mar 26, 2024
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
Outdated
Show resolved
Hide resolved
lsm1
force-pushed
the
branch-kyuubi-5373
branch
from
60852c0 to
559845c
Compare
4 tasks
cxzl25
reviewed
Apr 28, 2024
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala
Outdated
Show resolved
Hide resolved
cxzl25
reviewed
Apr 28, 2024
kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/EngineServiceDiscovery.scala
Outdated
Show resolved
Hide resolved
cxzl25
reviewed
Apr 28, 2024
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
Outdated
Show resolved
Hide resolved
lsm1
force-pushed
the
branch-kyuubi-5373
branch
from
559845c to
688ea74
Compare
cxzl25
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
close #5373
This pull request aims to support adaptive engine selection. The specific improvements are as follows:
Spark Engine Reports Status to Zookeeper Regularly: We have modified the Spark engine to periodically report the counts of its
OpenSessionCountandActiveTaskto Zookeeper.Server Selects Engine Based on Load: The server will select the engine with the lightest load for task allocation based on the information obtained from Zookeeper.
New Engine is Created When OpenSession Exceeds Threshold: If the
OpenSessioncount of all engines exceeds a set threshold, the server will submit a new engine.How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Was this patch authored or co-authored using generative AI tooling?