-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYUUBI #5600] Fix flaky test SessionsResourceSuite #5675
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5675 +/- ##
============================================
- Coverage 61.47% 61.41% -0.07%
Complexity 23 23
============================================
Files 603 603
Lines 35644 35664 +20
Branches 4875 4876 +1
============================================
- Hits 21913 21902 -11
- Misses 11358 11380 +22
- Partials 2373 2382 +9 see 11 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
@yaooqinn review? |
yaooqinn
reviewed
Nov 13, 2023
kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/SessionsResourceSuite.scala
Outdated
Show resolved
Hide resolved
yaooqinn
reviewed
Nov 13, 2023
kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/SessionsResourceSuite.scala
Show resolved
Hide resolved
yaooqinn
approved these changes
Nov 13, 2023
cxzl25
changed the title
[#5600] Fix flaky test SessionsResourceSuite
[KYUUBI #5600] Fix flaky test SessionsResourceSuite
Nov 13, 2023
Thank you, merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Because the server process is async, so when we test in ci or local, because our test operation is synchronize, but the server process is async, it will random failed, so we need to fix the problem to make sure the random test not happend.
In the SessionsResourceSuite, there may have 2 random test case failed
close #5600
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Was this patch authored or co-authored using generative AI tooling?
No