[KYUUBI #5690][AUTHZ] Support insert into/overwrite path-based table for Delta Lake in Authz #5691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
insert into insert overwrite |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5691 +/- ##
============================================
- Coverage 61.46% 61.40% -0.06%
Complexity 23 23
============================================
Files 604 607 +3
Lines 35697 35735 +38
Branches 4889 4896 +7
============================================
+ Hits 21942 21944 +2
- Misses 11380 11402 +22
- Partials 2375 2389 +14 ☔ View full report in Codecov by Sentry. |
yaooqinn
reviewed
Nov 15, 2023
| val maybeCatalogPlugin = invokeAs[Option[AnyRef]](v2Relation, "catalog") | ||
| val maybeCatalog = maybeCatalogPlugin.flatMap(catalogPlugin => | ||
| plan.find(_.getClass.getSimpleName == "DataSourceV2Relation") match { | ||
| case Some(v2Relation @ DataSourceV2Relation(table, _, catalog, identifier, _)) |
There was a problem hiding this comment.
Let‘s use v2Relation.xx instead of unapply which is easy to break
yaooqinn
reviewed
Nov 15, 2023
| override def apply(spark: SparkSession, v1: AnyRef): Seq[Uri] = { | ||
| val plan = v1.asInstanceOf[LogicalPlan] | ||
| plan.find(_.getClass.getSimpleName == "DataSourceV2Relation") match { | ||
| case Some(DataSourceV2Relation(_, _, _, Some(identifier), _)) |
yaooqinn
approved these changes
Nov 16, 2023
|
thanks, merged to master |
|
Thanks, @yaooqinn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
To close #5690 .
Support insert into/overwrite path-based table for Delta Lake in Authz plugin.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Was this patch authored or co-authored using generative AI tooling?
No.