Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Fix match may not be exhaustive in Scala 2.13 #5716

Closed
wants to merge 1 commit into from

Conversation

cxzl25
Copy link
Contributor

@cxzl25 cxzl25 commented Nov 16, 2023

🔍 Description

Issue References 🔗

https://github.com/apache/kyuubi/actions/runs/6885433363/job/18729567019

Error: ] /home/runner/work/kyuubi/kyuubi/extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/serde/tableExtractors.scala:259: match may not be exhaustive.
It would fail on the following inputs: SubqueryAlias(_, (x: org.apache.spark.sql.catalyst.plans.logical.LogicalPlan forSome x not in org.apache.spark.sql.catalyst.plans.logical.SubqueryAlias)), SubqueryAlias(_, SubqueryAlias(_, _))

Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklists

📝 Author Self Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • This patch was not authored or co-authored using Generative Tooling

📝 Committer Pre-Merge Checklist

  • Pull request title is okay.
  • No license issues.
  • Milestone correctly set?
  • Test coverage is ok
  • Assignees are selected.
  • Minimum number of approvals
  • No changes are requested

Be nice. Be informative.

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (10d0aec) 61.50% compared to head (5c761a8) 61.39%.
Report is 2 commits behind head on master.

Files Patch % Lines
...ubi/plugin/spark/authz/serde/tableExtractors.scala 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5716      +/-   ##
============================================
- Coverage     61.50%   61.39%   -0.12%     
  Complexity       23       23              
============================================
  Files           607      607              
  Lines         35727    35758      +31     
  Branches       4891     4900       +9     
============================================
- Hits          21974    21953      -21     
- Misses        11381    11424      +43     
- Partials       2372     2381       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cxzl25 cxzl25 added this to the v1.9.0 milestone Nov 17, 2023
@cxzl25 cxzl25 closed this in 019bd50 Nov 17, 2023
@cxzl25
Copy link
Contributor Author

cxzl25 commented Nov 17, 2023

Thanks, merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants