Infer the proxy user automatically for delete batch operation #5717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
force-pushed
the
hive_server2_proxy_user
branch
from
851a0bd to
d4ba200
Compare
turboFei
changed the title
turboFei
force-pushed
the
hive_server2_proxy_user
branch
from
d4ba200 to
e3670a4
Compare
turboFei
changed the title
turboFei
force-pushed
the
hive_server2_proxy_user
branch
from
e3670a4 to
7340401
Compare
turboFei
force-pushed
the
hive_server2_proxy_user
branch
from
7340401 to
cef9e32
Compare
|
I think it may be useful in the future. Currently, we only have a true-false-switch for roles: admin/non-admin. But in the future, we may introduce the real RBAC system, which means we can control |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5717 +/- ##
============================================
- Coverage 61.40% 61.30% -0.11%
Complexity 23 23
============================================
Files 607 607
Lines 35755 35815 +60
Branches 4900 4912 +12
============================================
+ Hits 21957 21958 +1
- Misses 11413 11467 +54
- Partials 2385 2390 +5 ☔ View full report in Codecov by Sentry. |
pan3793
reviewed
Nov 17, 2023
pan3793
reviewed
Nov 17, 2023
kyuubi-ctl/src/test/scala/org/apache/kyuubi/ctl/BatchCliArgumentsSuite.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Nov 17, 2023
kyuubi-rest-client/src/main/java/org/apache/kyuubi/client/BatchRestApi.java
Show resolved
Hide resolved
|
have addressed all comments and updated the pr description. @pan3793 |
pan3793
reviewed
Nov 17, 2023
turboFei
force-pushed
the
hive_server2_proxy_user
branch
from
e6e0b75 to
55bcf40
Compare
pan3793
approved these changes
Nov 17, 2023
turboFei
force-pushed
the
hive_server2_proxy_user
branch
from
55bcf40 to
70ad7e7
Compare
turboFei
added a commit
to turboFei/kyuubi
that referenced
this pull request
Nov 17, 2023
…tch operation Infer the batch user from session or metadata, user do not need to specify the proxy user anymore. This pr also align the behavior of BatchesResource with that of SessionsResource and OperationsResource(no proxy user parameter). For Kyuubi Batch, Session and Operation, these resources have the user attiribute. So we only need to check whether the authentication user has the permission to access the resource. This pull request fixes # Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) --- - [x] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project - [x] I have performed a self-review - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) - [x] Pull request title is okay. - [x] No license issues. - [x] Milestone correctly set? - [ ] Test coverage is ok - [x] Assignees are selected. - [x] Minimum number of approvals - [x] No changes are requested **Be nice. Be informative.** Closes apache#5717 from turboFei/hive_server2_proxy_user. Closes apache#5717 70ad7e7 [fwang12] comment c721a75 [fwang12] ignore da92bd5 [fwang12] fix ut 9a197d0 [fwang12] doc c8ed5f9 [fwang12] ut cef9e32 [fwang12] do not use proxy user Authored-by: fwang12 <[email protected]> Signed-off-by: fwang12 <[email protected]> (cherry picked from commit 3478fc9) Signed-off-by: fwang12 <[email protected]>
36 tasks
|
thanks, merged to master and branch-1.8 |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Infer the batch user from session or metadata, user do not need to specify the proxy user anymore.
This pr also align the behavior of BatchesResource with that of SessionsResource and OperationsResource(no proxy user parameter).
For Kyuubi Batch, Session and Operation, these resources have the user attiribute.
So we only need to check whether the authentication user has the permission to access the resource.
Issue References 🔗
This pull request fixes #
Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklists
📝 Author Self Checklist
📝 Committer Pre-Merge Checklist
Be nice. Be informative.