[TEST] Fix flaky test in TPCHQuerySuite #5720

cxzl25 · 2023-11-17T09:04:56Z

🔍 Description

Issue References 🔗

This pull request fixes #

Describe Your Solution 🔧

TPCHQuerySuite:

run query on tiny *** FAILED ***
q14 (TPCHQuerySuite.scala:74)

https://github.com/apache/kyuubi/actions/runs/6891462902/job/18750551743?pr=5716

Types of changes 🔖

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests

Checklists

📝 Author Self Checklist

My code follows the style guidelines of this project
I have performed a self-review
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
This patch was not authored or co-authored using Generative Tooling

📝 Committer Pre-Merge Checklist

Be nice. Be informative.

cxzl25 · 2023-11-17T09:07:31Z

extensions/spark/kyuubi-spark-connector-tpch/src/main/resources/kyuubi/tpch/q14.sql

        when p_type like 'PROMO%'
            then l_extendedprice * (1 - l_discount)
        else 0
-    end) / sum(l_extendedprice * (1 - l_discount)) as promo_revenue
+    end) / sum(l_extendedprice * (1 - l_discount)), 2) as promo_revenue


GA

query q14 result: List([15.486545812284065])

Local Mac

query q14 result: List([15.486545812284069])

PR

query q14 result: List([15.49])

cxzl25 · 2023-11-17T09:08:39Z

...rk-connector-tpch/src/test/scala/org/apache/kyuubi/spark/connector/tpch/TPCHQuerySuite.scala

-          assert(sumHashResult == tuple._2)
-        } catch {
-          case cause: Throwable =>
-            fail(name, cause)


Cannot display the comparison results of assert

cxzl25 · 2023-11-17T09:08:44Z

...rk-connector-tpch/src/test/scala/org/apache/kyuubi/spark/connector/tpch/TPCHQuerySuite.scala

 * }}}
 *
 * To re-generate golden files for this suite:
 * {{{
- *   dev/gen/gen_tpcdh_queries.sh


codecov-commenter · 2023-11-17T10:23:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (765cdaa) 61.33% compared to head (0a9f3ed) 61.33%.
Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #5720   +/-   ##
=========================================
  Coverage     61.33%   61.33%           
  Complexity       23       23           
=========================================
  Files           607      607           
  Lines         35817    35820    +3     
  Branches       4912     4914    +2     
=========================================
+ Hits          21967    21970    +3     
+ Misses        11466    11463    -3     
- Partials       2384     2387    +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# 🔍 Description ## Issue References 🔗 This pull request fixes # ## Describe Your Solution 🔧 TPCHQuerySuite: - run query on tiny *** FAILED *** q14 (TPCHQuerySuite.scala:74) https://github.com/apache/kyuubi/actions/runs/6891462902/job/18750551743?pr=5716 ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklists ## 📝 Author Self Checklist - [ ] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project - [ ] I have performed a self-review - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) ## 📝 Committer Pre-Merge Checklist - [x] Pull request title is okay. - [x] No license issues. - [ ] Milestone correctly set? - [ ] Test coverage is ok - [ ] Assignees are selected. - [ ] Minimum number of approvals - [ ] No changes are requested **Be nice. Be informative.** Closes #5720 from cxzl25/tpch_double. Closes #5720 0a9f3ed [sychen] round febe647 [sychen] round 8db6325 [sychen] round 75e1699 [sychen] fix q14 Authored-by: sychen <[email protected]> Signed-off-by: Shaoyun Chen <[email protected]> (cherry picked from commit 25bb7e5) Signed-off-by: Shaoyun Chen <[email protected]>

cxzl25 · 2023-11-20T03:19:56Z

Thanks, merged to master/1.8/1.7.

# 🔍 Description ## Issue References 🔗 This pull request fixes # ## Describe Your Solution 🔧 TPCHQuerySuite: - run query on tiny *** FAILED *** q14 (TPCHQuerySuite.scala:74) https://github.com/apache/kyuubi/actions/runs/6891462902/job/18750551743?pr=5716 ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklists ## 📝 Author Self Checklist - [ ] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project - [ ] I have performed a self-review - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) ## 📝 Committer Pre-Merge Checklist - [x] Pull request title is okay. - [x] No license issues. - [ ] Milestone correctly set? - [ ] Test coverage is ok - [ ] Assignees are selected. - [ ] Minimum number of approvals - [ ] No changes are requested **Be nice. Be informative.** Closes #5720 from cxzl25/tpch_double. Closes #5720 0a9f3ed [sychen] round febe647 [sychen] round 8db6325 [sychen] round 75e1699 [sychen] fix q14 Authored-by: sychen <[email protected]> Signed-off-by: Shaoyun Chen <[email protected]> (cherry picked from commit 25bb7e5)

…se notes # 🔍 Description ## Issue References 🔗 Currently, we use a rather primitive way to manually write release notes from scratch, and some of the mechanical and repetitive work can be simplified by the scripts. ## Describe Your Solution 🔧 Adds a script to simplify the process of creating release notes. Note: it just simplifies some processes, the release manager still needs to tune the outputs by hand. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 ``` RELEASE_TAG=v1.8.1 PREVIOUS_RELEASE_TAG=v1.8.0 build/release/pre_gen_release_notes.py ``` ``` $ head build/release/commits-v1.8.1.txt [KYUUBI #5981] Deploy Spark Hive connector with Scala 2.13 to Maven Central [KYUUBI #6058] Make Jetty server stop timeout configurable [KYUUBI #5952][1.8] Disconnect connections without running operations after engine maxlife time graceful period [KYUUBI #6048] Assign serviceNode and add volatile for variables [KYUUBI #5991] Error on reading Atlas properties composed of multi values [KYUUBI #6045] [REST] Sync the AdminRestApi with the AdminResource Apis [KYUUBI #6047] [CI] Free up disk space [KYUUBI #6036] JDBC driver conditional sets fetchSize on opening session [KYUUBI #6028] Exited spark-submit process should not block batch submit queue [KYUUBI #6018] Speed up GetTables operation for Spark session catalog ``` ``` $ head build/release/contributors-v1.8.1.txt * Shaoyun Chen -- [KYUUBI #5857][KYUUBI #5720][KYUUBI #5785][KYUUBI #5617] * Chao Chen -- [KYUUBI #5750] * Flyangz -- [KYUUBI #5832] * Pengqi Li -- [KYUUBI #5713] * Bowen Liang -- [KYUUBI #5730][KYUUBI #5802][KYUUBI #5767][KYUUBI #5831][KYUUBI #5801][KYUUBI #5754][KYUUBI #5626][KYUUBI #5811][KYUUBI #5853][KYUUBI #5765] * Paul Lin -- [KYUUBI #5799][KYUUBI #5814] * Senmiao Liu -- [KYUUBI #5969][KYUUBI #5244] * Xiao Liu -- [KYUUBI #5962] * Peiyue Liu -- [KYUUBI #5331] * Junjie Ma -- [KYUUBI #5789] ``` --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6074 from pan3793/release-script. Closes #6074 3d5ec20 [Cheng Pan] credits 1765279 [Cheng Pan] Add a script to simplify the process of creating release notes Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]>

… release notes # 🔍 Description ## Issue References 🔗 Currently, we use a rather primitive way to manually write release notes from scratch, and some of the mechanical and repetitive work can be simplified by the scripts. ## Describe Your Solution 🔧 Adds a script to simplify the process of creating release notes. Note: it just simplifies some processes, the release manager still needs to tune the outputs by hand. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 ``` RELEASE_TAG=v1.8.1 PREVIOUS_RELEASE_TAG=v1.8.0 build/release/pre_gen_release_notes.py ``` ``` $ head build/release/commits-v1.8.1.txt [KYUUBI apache#5981] Deploy Spark Hive connector with Scala 2.13 to Maven Central [KYUUBI apache#6058] Make Jetty server stop timeout configurable [KYUUBI apache#5952][1.8] Disconnect connections without running operations after engine maxlife time graceful period [KYUUBI apache#6048] Assign serviceNode and add volatile for variables [KYUUBI apache#5991] Error on reading Atlas properties composed of multi values [KYUUBI apache#6045] [REST] Sync the AdminRestApi with the AdminResource Apis [KYUUBI apache#6047] [CI] Free up disk space [KYUUBI apache#6036] JDBC driver conditional sets fetchSize on opening session [KYUUBI apache#6028] Exited spark-submit process should not block batch submit queue [KYUUBI apache#6018] Speed up GetTables operation for Spark session catalog ``` ``` $ head build/release/contributors-v1.8.1.txt * Shaoyun Chen -- [KYUUBI apache#5857][KYUUBI apache#5720][KYUUBI apache#5785][KYUUBI apache#5617] * Chao Chen -- [KYUUBI apache#5750] * Flyangz -- [KYUUBI apache#5832] * Pengqi Li -- [KYUUBI apache#5713] * Bowen Liang -- [KYUUBI apache#5730][KYUUBI apache#5802][KYUUBI apache#5767][KYUUBI apache#5831][KYUUBI apache#5801][KYUUBI apache#5754][KYUUBI apache#5626][KYUUBI apache#5811][KYUUBI apache#5853][KYUUBI apache#5765] * Paul Lin -- [KYUUBI apache#5799][KYUUBI apache#5814] * Senmiao Liu -- [KYUUBI apache#5969][KYUUBI apache#5244] * Xiao Liu -- [KYUUBI apache#5962] * Peiyue Liu -- [KYUUBI apache#5331] * Junjie Ma -- [KYUUBI apache#5789] ``` --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6074 from pan3793/release-script. Closes apache#6074 3d5ec20 [Cheng Pan] credits 1765279 [Cheng Pan] Add a script to simplify the process of creating release notes Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]>

github-actions bot added module:spark module:extensions labels Nov 17, 2023

fix q14

75e1699

cxzl25 force-pushed the tpch_double branch from f44f392 to 75e1699 Compare November 17, 2023 09:06

cxzl25 commented Nov 17, 2023

View reviewed changes

pan3793 approved these changes Nov 17, 2023

View reviewed changes

cxzl25 marked this pull request as draft November 17, 2023 11:29

cxzl25 added 2 commits November 17, 2023 22:15

round

8db6325

round

febe647

cxzl25 changed the title ~~[TEST] Fix q14 in TPCHQuerySuite~~ [TEST] Fix flaky test in TPCHQuerySuite Nov 17, 2023

round

0a9f3ed

cxzl25 marked this pull request as ready for review November 18, 2023 04:00

cxzl25 self-assigned this Nov 18, 2023

cxzl25 modified the milestones: v1.8.1, v1.9.0 Nov 18, 2023

cxzl25 requested a review from pan3793 November 20, 2023 02:54

pan3793 approved these changes Nov 20, 2023

View reviewed changes

cxzl25 closed this in 25bb7e5 Nov 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TEST] Fix flaky test in TPCHQuerySuite #5720

[TEST] Fix flaky test in TPCHQuerySuite #5720

cxzl25 commented Nov 17, 2023 •

edited by pan3793

Loading

cxzl25 Nov 17, 2023 •

edited

Loading

cxzl25 Nov 17, 2023

cxzl25 Nov 17, 2023

codecov-commenter commented Nov 17, 2023 •

edited

Loading

cxzl25 commented Nov 20, 2023 •

edited

Loading

[TEST] Fix flaky test in TPCHQuerySuite #5720

[TEST] Fix flaky test in TPCHQuerySuite #5720

Conversation

cxzl25 commented Nov 17, 2023 • edited by pan3793 Loading

🔍 Description

Issue References 🔗

Describe Your Solution 🔧

Types of changes 🔖

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests

Checklists

📝 Author Self Checklist

📝 Committer Pre-Merge Checklist

cxzl25 Nov 17, 2023 • edited Loading

Choose a reason for hiding this comment

cxzl25 Nov 17, 2023

Choose a reason for hiding this comment

cxzl25 Nov 17, 2023

Choose a reason for hiding this comment

codecov-commenter commented Nov 17, 2023 • edited Loading

Codecov Report

cxzl25 commented Nov 20, 2023 • edited Loading

cxzl25 commented Nov 17, 2023 •

edited by pan3793

Loading

cxzl25 Nov 17, 2023 •

edited

Loading

codecov-commenter commented Nov 17, 2023 •

edited

Loading

cxzl25 commented Nov 20, 2023 •

edited

Loading