[WIP] SBT build support #5721
Closed
[WIP] SBT build support #5721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The main error in package is the scala plugin's args in kyuubi parent pom The sbt error info is if we not override the plugin in pom can we remove them? |
pan3793
reviewed
Nov 17, 2023
| # When creating new tests for Spark SQL Hive, the HADOOP_CLASSPATH must contain the hive jars so | ||
| # that we can run Hive to generate the golden answer. This is not required for normal development | ||
| # or testing. | ||
| if [ -n "$HIVE_HOME" ]; then |
There was a problem hiding this comment.
consider copying this file from celeborn projects, we did some explores and optimization before
|
remove silencer could break the Maven build. cc @cxzl25 |
|
Cool. What's the scope of supported modules? Could you add some examples in description for clarification, for either building all modules or part of them? |
currently, the main prolem is sbt package can not support some arguments, #5721 (comment) so i can not give the module scope, there hava many module can not package if their pom not override the scala plugin. i'm not sure remove those arguments will break the maven build, or overwrite the scala-plugin in the module's pom, could you give me some suggest? @cxzl25 |
|
https://github.com/ghik/silencer/tree/master |
davidyuan1223
changed the title
you are right. it works after applying the following patch. diff --git a/project/Build.scala b/project/Build.scala
index 6f728747b..bc20ebcf8 100644
--- a/project/Build.scala
+++ b/project/Build.scala
@@ -25,6 +25,8 @@ import sbtprotoc.ProtocPlugin.autoImport._
import sbtassembly.AssemblyPlugin.autoImport._
import scala.util.Properties
+import sbt.librarymanagement.{ VersionNumber, SemanticSelector }
+
object KyuubiBuild extends PomBuild {
@@ -48,6 +50,7 @@ object KyuubiBuild extends PomBuild {
val kyuubiCommon = ProjectRef(buildLocation, "kyuubi-common")
val kyuubiServer = ProjectRef(buildLocation, "kyuubi-server")
+ val kyuubiUtilScala = ProjectRef(buildLocation, "kyuubi-util-scala")
val spark3Client = ProjectRef(buildLocation, "spark-3-shaded")
@@ -56,13 +59,76 @@ object KyuubiBuild extends PomBuild {
client, server, ha, _*
) = Seq(
"kyuubi-rest-client", "kyuubi-servers", "worker"
- ).map(ProjectRef(buildLocation, _)).++(Seq(kyuubiCommon, kyuubiServer, spark3Client))
+ ).map(ProjectRef(buildLocation, _)).++(Seq(kyuubiCommon, kyuubiUtilScala, kyuubiServer, spark3Client))
- lazy val sharedSettings = Seq(
+ lazy val sharedSettings = compilerWarningSettings ++ Seq(
SbtPomKeys.profiles.:=(profiles)
)
+ val silencerVersion = "1.7.13"
+ lazy val compilerWarningSettings: Seq[sbt.Def.Setting[_]] = Seq(
+ libraryDependencies ++= {
+ if (VersionNumber(scalaVersion.value).matchesSemVer(SemanticSelector("<2.13.2"))) {
+ Seq(
+ compilerPlugin("com.github.ghik" % "silencer-plugin" % silencerVersion cross CrossVersion.full),
+ "com.github.ghik" % "silencer-lib" % silencerVersion % Provided cross CrossVersion.full
+ )
+ } else {
+ Seq.empty
+ }
+ },
+ (Compile / scalacOptions) ++= {
+ if (VersionNumber(scalaVersion.value).matchesSemVer(SemanticSelector("<2.13.2"))) {
+ Seq(
+ "-Xfatal-warnings",
+ "-deprecation",
+ "-Ywarn-unused-import",
+ "-P:silencer:globalFilters=.*deprecated.*" //regex to catch deprecation warnings and suppress them
+ )
+ } else {
+ Seq(
+ // replace -Xfatal-warnings with fine-grained configuration, since 2.13.2
+ // verbose warning on deprecation, error on all others
+ // see `scalac -Wconf:help` for details
+ "-Wconf:cat=deprecation:wv,any:e",
+ // 2.13-specific warning hits to be muted (as narrowly as possible) and addressed separately
+ "-Wunused:imports",
+ "-Wconf:cat=lint-multiarg-infix:wv",
+ "-Wconf:cat=other-nullary-override:wv",
+ "-Wconf:cat=other-match-analysis&site=org.apache.spark.sql.catalyst.catalog.SessionCatalog.lookupFunction.catalogFunction:wv",
+ "-Wconf:cat=other-pure-statement&site=org.apache.spark.streaming.util.FileBasedWriteAheadLog.readAll.readFile:wv",
+ "-Wconf:cat=other-pure-statement&site=org.apache.spark.scheduler.OutputCommitCoordinatorSuite.<local OutputCommitCoordinatorSuite>.futureAction:wv",
+ "-Wconf:cat=other-pure-statement&site=org.apache.spark.sql.streaming.sources.StreamingDataSourceV2Suite.testPositiveCase.\\$anonfun:wv",
+ // SPARK-33775 Suppress compilation warnings that contain the following contents.
+ // TODO(SPARK-33805): Undo the corresponding deprecated usage suppression rule after
+ // fixed.
+ "-Wconf:msg=^(?=.*?method|value|type|object|trait|inheritance)(?=.*?deprecated)(?=.*?since 2.13).+$:s",
+ "-Wconf:msg=^(?=.*?Widening conversion from)(?=.*?is deprecated because it loses precision).+$:s",
+ "-Wconf:msg=Auto-application to \\`\\(\\)\\` is deprecated:s",
+ "-Wconf:msg=method with a single empty parameter list overrides method without any parameter list:s",
+ "-Wconf:msg=method without a parameter list overrides a method with a single empty one:s",
+ // SPARK-35574 Prevent the recurrence of compilation warnings related to `procedure syntax is deprecated`
+ "-Wconf:cat=deprecation&msg=procedure syntax is deprecated:e",
+ // SPARK-35496 Upgrade Scala to 2.13.7 and suppress:
+ // 1. `The outer reference in this type test cannot be checked at run time`
+ // 2. `the type test for pattern TypeA cannot be checked at runtime because it
+ // has type parameters eliminated by erasure`
+ // 3. `abstract type TypeA in type pattern Seq[TypeA] (the underlying of
+ // Seq[TypeA]) is unchecked since it is eliminated by erasure`
+ // 4. `fruitless type test: a value of TypeA cannot also be a TypeB`
+ "-Wconf:cat=unchecked&msg=outer reference:s",
+ "-Wconf:cat=unchecked&msg=eliminated by erasure:s",
+ "-Wconf:msg=^(?=.*?a value of type)(?=.*?cannot also be).+$:s",
+ // TODO(SPARK-43850): Remove the following suppression rules and remove `import scala.language.higherKinds`
+ // from the corresponding files when Scala 2.12 is no longer supported.
+ "-Wconf:cat=unused-imports&src=org\\/apache\\/spark\\/graphx\\/impl\\/VertexPartitionBase.scala:s",
+ "-Wconf:cat=unused-imports&src=org\\/apache\\/spark\\/graphx\\/impl\\/VertexPartitionBaseOps.scala:s"
+ )
+ }
+ }
+ )
+
val projectsMap: Map[String, Seq[Setting[_]]] = Map.empty
def enable(settings: Seq[Setting[_]])(projectRef: ProjectRef): Any = { |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5721 +/- ##
============================================
+ Coverage 61.33% 61.35% +0.01%
Complexity 23 23
============================================
Files 607 607
Lines 35817 35820 +3
Branches 4912 4912
============================================
+ Hits 21967 21976 +9
+ Misses 11466 11463 -3
+ Partials 2384 2381 -3 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
module:kubernetes
kind:infra
|
@cfmcgrady hello, could you give me some adive, i have added the property |
davidyuan1223
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
Describe Your Solution 🔧
Currently maven build is slowly, we need a faster tool to build, so we can support sbt in project, it's quickly than maven
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklists
📝 Author Self Checklist
📝 Committer Pre-Merge Checklist
Be nice. Be informative.