-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Introduce Kyuubi Web UI Engine Page #5762
Conversation
@zwangsheng plz help review it. Thanks. |
docs/client/ui/engine_ui.md
Outdated
| Version | The version of the Kyuubi server associated with this engine | | ||
| Operation | Extra operations that users can do further.<br/> 1. View native engine UI<br/>find and select the engine you wish to view its native UI. <br/>clink on the view button, you should be redirected to the native engine UI powered by Kyuubi proxy. <br/>2. Delete the specified engine gracefully <br/>select the specific engine you would like to delete from the Engine Management page. <br/>click on delete button and confirm your choice, then the engine will be remove from service discovery like Zookeeper, ETCD and etc. <br/>The engine will eventually be shut down once all the jobs running on it inside are finished. | | ||
|
||
![workspace](../../imgs/ui/spark_ui.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, we don't need this Spark UI Image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.
docs/client/ui/engine_ui.md
Outdated
| Share Level | The share level of engine, such as user, connection, group and server | | ||
| User | The user created the engine | | ||
| Version | The version of the Kyuubi server associated with this engine | | ||
| Operation | Extra operations that users can do further.<br/> 1. View native engine UI<br/>find and select the engine you wish to view its native UI. <br/>clink on the view button, you should be redirected to the native engine UI powered by Kyuubi proxy. <br/>2. Delete the specified engine gracefully <br/>select the specific engine you would like to delete from the Engine Management page. <br/>click on delete button and confirm your choice, then the engine will be remove from service discovery like Zookeeper, ETCD and etc. <br/>The engine will eventually be shut down once all the jobs running on it inside are finished. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The engine will eventually be shut down once all the jobs running on it inside are finished.
The engine will eventually be shut down once all connected session closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.
docs/client/ui/engine_ui.md
Outdated
|
||
This engine UI is able to help you understand status of the engine behind Kyuubi servers. | ||
|
||
## Engine Management details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Engine Management details => Engine Management Details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Thanks!
done. @zwangsheng
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5762 +/- ##
============================================
- Coverage 61.40% 61.37% -0.03%
Complexity 23 23
============================================
Files 607 607
Lines 35897 35940 +43
Branches 4923 4932 +9
============================================
+ Hits 22042 22059 +17
- Misses 11474 11494 +20
- Partials 2381 2387 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, would you re-upload latest screenshoot in PR desc, it's failed for now.
PTAL @pan3793
Thanks. |
Hi @zhaohehuhu, is it possible to reduce the size of |
Yup. It compressed to 27 KB |
Thank you all, merged to master |
🔍 Description
Issue References 🔗
This pull request fixes #5572
Describe Your Solution 🔧
Introduce Kyuubi Web UI Engine Page as the screenshot shown.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklists
📝 Author Self Checklist
📝 Committer Pre-Merge Checklist
Be nice. Be informative.