[KYUUBI #5944] Introduce Prometheus and Grafana for Kyuubi Playground #5945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
reviewed
Jan 4, 2024
pan3793
reviewed
Jan 4, 2024
docker/playground/.env
Outdated
| @@ -28,3 +28,5 @@ SPARK_VERSION=3.4.2 | |||
| SPARK_BINARY_VERSION=3.4 | |||
| SPARK_HADOOP_VERSION=3.3.4 | |||
| ZOOKEEPER_VERSION=3.6.3 | |||
| PROMETHEUS_VERSION=v2.45.2 | |||
There was a problem hiding this comment.
prometheus docker image requires.
See more tags in https://hub.docker.com/r/prom/prometheus/tags
There was a problem hiding this comment.
that's tag, not version. if wanted, we may use apache-kyuubi:${KYUUBI_VERSION}-spark or something
pan3793
changed the title
pan3793
reviewed
Jan 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5945 +/- ##
============================================
- Coverage 61.26% 61.18% -0.09%
Complexity 23 23
============================================
Files 621 622 +1
Lines 36864 36882 +18
Branches 5014 5014
============================================
- Hits 22586 22566 -20
- Misses 11848 11877 +29
- Partials 2430 2439 +9 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Cheng Pan <[email protected]>
pan3793
approved these changes
Jan 5, 2024
|
Thanks, merged to master |
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Feb 5, 2024
…ground # 🔍 Description ## Issue References 🔗 This pull request fixes apache#5944 ## Describe Your Solution 🔧 Add prometheus and grafana docker image to docker compose yaml, and by defaults, prometheus will get kyuubi server's metrics and grafana set prometheus as default datasource. Help developers quickly build a dashboard development environment. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 In local test - [x] all container start success - [x] By defaults, prometheus get kyuubi's metrics - [x] Grafana take the prometheus as default datasource #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#5945 from zwangsheng/KYUUBI#5944. Closes apache#5944 031deed [Binjie Yang] Update docker/playground/README.md dbf41e3 [zwangsheng] declare metrics related config e6efe30 [zwangsheng] make grafana as anonymous 404dd42 [zwangsheng] fix comments f7ca4ae [zwangsheng] fix prometheus 089f8d0 [zwangsheng] eof 6872078 [zwangsheng] add license header cfa6edf [zwangsheng] [KYUUBI apache#5944][Improvement] Introduce Prometheus and Grafana for Kyuubi Playground Lead-authored-by: zwangsheng <[email protected]> Co-authored-by: Binjie Yang <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
…ground # 🔍 Description ## Issue References 🔗 This pull request fixes apache#5944 ## Describe Your Solution 🔧 Add prometheus and grafana docker image to docker compose yaml, and by defaults, prometheus will get kyuubi server's metrics and grafana set prometheus as default datasource. Help developers quickly build a dashboard development environment. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 In local test - [x] all container start success - [x] By defaults, prometheus get kyuubi's metrics - [x] Grafana take the prometheus as default datasource #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#5945 from zwangsheng/KYUUBI#5944. Closes apache#5944 031deed [Binjie Yang] Update docker/playground/README.md dbf41e3 [zwangsheng] declare metrics related config e6efe30 [zwangsheng] make grafana as anonymous 404dd42 [zwangsheng] fix comments f7ca4ae [zwangsheng] fix prometheus 089f8d0 [zwangsheng] eof 6872078 [zwangsheng] add license header cfa6edf [zwangsheng] [KYUUBI apache#5944][Improvement] Introduce Prometheus and Grafana for Kyuubi Playground Lead-authored-by: zwangsheng <[email protected]> Co-authored-by: Binjie Yang <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request fixes #5944
Describe Your Solution 🔧
Add prometheus and grafana docker image to docker compose yaml, and by defaults, prometheus will get kyuubi server's metrics and grafana set prometheus as default datasource.
Help developers quickly build a dashboard development environment.
Types of changes 🔖
Test Plan 🧪
In local test
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.