[KYUUBI #5894] Separate closed and online sessions/statements in the SparkUI's engine tab #5946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the SparkUI's engine tab
cxzl25
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5946 +/- ##
============================================
- Coverage 61.16% 61.08% -0.09%
Complexity 23 23
============================================
Files 621 622 +1
Lines 36864 37036 +172
Branches 5014 5023 +9
============================================
+ Hits 22547 22622 +75
- Misses 11878 11975 +97
Partials 2439 2439 ☔ View full report in Codecov by Sentry. |
|
The idea and UI LGTM (haven't gone through the code), there are compiling errors on Scala 2.13, could you please fix it? |
I will fix it soon. |
beryllw
commented
Jan 5, 2024
| data, | ||
| "kyuubi", | ||
| UIUtils.prependBaseUri(request, parent.basePath), | ||
| s"${sessionTage}-table").table(sessionPage) |
There was a problem hiding this comment.
fix html document id duplicate
added 2 commits
January 5, 2024 16:00
pan3793
reviewed
Jan 15, 2024
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/ui/EnginePage.scala
Outdated
Show resolved
Hide resolved
pan3793
approved these changes
Jan 15, 2024
added 2 commits
January 16, 2024 16:39
pan3793
reviewed
Jan 16, 2024
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/ui/EnginePage.scala
Outdated
Show resolved
Hide resolved
pan3793
approved these changes
Jan 16, 2024
pan3793
changed the title
|
Merged to master |
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Feb 5, 2024
…n the SparkUI's engine tab Separate closed and online sessions[statements] in the SparkUI's engine tab # 🔍 Description ## Issue References 🔗 This pull request fixes apache#5894 ## Describe Your Solution 🔧 Separate closed and online sessions[statements] in the SparkUI's engine tab  ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests unit test will add soon. --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#5946 from Kwafoor/kyuubi_5894. Closes apache#5894 ade3fc1 [wangjunbo] fix d71a61a [wangjunbo] rename span id 0b600f5 [wangjunbo] rename span id f56ca7e [wangjunbo] fix code 79b8e33 [wangjunbo] delete test code cd3ecac [wangjunbo] fix CI test, fix html document id duplicate 3a0e370 [wangjunbo] [KYUUBI apache#5894] fix scalastyle check 83c7b15 [wangjunbo] [KYUUBI apache#5894] Separate closed and online sessions[statements] in the SparkUI's engine tab Authored-by: wangjunbo <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
…n the SparkUI's engine tab Separate closed and online sessions[statements] in the SparkUI's engine tab # 🔍 Description ## Issue References 🔗 This pull request fixes apache#5894 ## Describe Your Solution 🔧 Separate closed and online sessions[statements] in the SparkUI's engine tab  ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests unit test will add soon. --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#5946 from Kwafoor/kyuubi_5894. Closes apache#5894 ade3fc1 [wangjunbo] fix d71a61a [wangjunbo] rename span id 0b600f5 [wangjunbo] rename span id f56ca7e [wangjunbo] fix code 79b8e33 [wangjunbo] delete test code cd3ecac [wangjunbo] fix CI test, fix html document id duplicate 3a0e370 [wangjunbo] [KYUUBI apache#5894] fix scalastyle check 83c7b15 [wangjunbo] [KYUUBI apache#5894] Separate closed and online sessions[statements] in the SparkUI's engine tab Authored-by: wangjunbo <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate closed and online sessions[statements] in the SparkUI's engine tab
🔍 Description
Issue References 🔗
This pull request fixes #5894
Describe Your Solution 🔧
Separate closed and online sessions[statements] in the SparkUI's engine tab
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
unit test will add soon.
Checklist 📝
Be nice. Be informative.