Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to build kyuubi-spark-authz-shaded into kyuubi-spark-sql-engine module #5994

Closed
wants to merge 1 commit into from

Conversation

turboFei
Copy link
Member

@turboFei turboFei commented Jan 18, 2024

🔍 Description

In this PR, I add a profile spark-authz-compile to make kyuubi-spark-authz-shaded module built into kyuubi-spark-sql-engine module.

It can make the authz integration more easily for kyuubi-spark-sql-engine.

Issue References 🔗

This pull request fixes #

Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@turboFei turboFei changed the title Support to built kyuubi-spark-authz-shaded into kyuubi-spark-sql-engine module Support to build kyuubi-spark-authz-shaded into kyuubi-spark-sql-engine module Jan 18, 2024
@turboFei turboFei requested a review from pan3793 January 18, 2024 21:38
@turboFei turboFei self-assigned this Jan 18, 2024
@turboFei turboFei added this to the v1.9.0 milestone Jan 18, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e9e2d18) 61.11% compared to head (338d36d) 61.06%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5994      +/-   ##
============================================
- Coverage     61.11%   61.06%   -0.06%     
  Complexity       23       23              
============================================
  Files           622      622              
  Lines         37035    37043       +8     
  Branches       5023     5025       +2     
============================================
- Hits          22634    22619      -15     
- Misses        11964    11973       +9     
- Partials       2437     2451      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bowenliang123
Copy link
Contributor

With the new profile activated, is the kyuubi-spark-authz-shaded shipped as a jar with kyuubi server or just embedded inside the spark SQL engine ?

@pan3793
Copy link
Member

pan3793 commented Jan 19, 2024

this may not be a good idea. engine's plugins use lots of engine's internal APIs which can not work across the engine's versions, we usually leave the engine's plugin separately.

@turboFei turboFei closed this Jan 19, 2024
@turboFei turboFei deleted the ranger_builtin branch January 19, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants