Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #6006][HELM] Support additional labels for service monitor #6019

Closed
wants to merge 2 commits into from
Closed

[KYUUBI #6006][HELM] Support additional labels for service monitor #6019

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed3fb0e
[KYUUBI #6006] Support additional labels for service monitor
sudohainguyen Jan 25, 2024
69a86c5
chore: simplify labels values
sudohainguyen Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions charts/kyuubi/templates/kyuubi-servicemonitor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ metadata:
name: {{ .Release.Name }}
labels:
{{- include "kyuubi.labels" . | nindent 4 }}
{{- if .Values.serviceMonitor.additionalLabels }}
{{- toYaml .Values.serviceMonitor.additionalLabels | nindent 4 }}
{{- end }}
spec:
selector:
matchLabels:
Expand Down
2 changes: 2 additions & 0 deletions charts/kyuubi/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,8 @@ serviceMonitor:
# The endpoints section in a ServiceMonitor specifies the metrics information for each target endpoint.
# This allows you to collect metrics from multiple Services across your Kubernetes cluster in a standardized and automated way.
endpoints: []
# Additional labels that can be used so ServiceMonitor will be discovered by Prometheus
additionalLabels: {}
sudohainguyen marked this conversation as resolved.
Show resolved Hide resolved

# Rules for the Prometheus Operator
prometheusRule:
Expand Down
Loading