Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #6031] Add more details for the CollectMetrics node #6035

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wForget
Copy link
Member

@wForget wForget commented Jan 31, 2024

🔍 Description

Issue References 🔗

This pull request fixes #6031

Describe Your Solution 🔧

image

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@ulysses-you
Copy link
Contributor

cc @zhouyifan279

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (208354c) 61.18% compared to head (368ecce) 61.07%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6035      +/-   ##
============================================
- Coverage     61.18%   61.07%   -0.11%     
  Complexity       23       23              
============================================
  Files           623      623              
  Lines         37144    37145       +1     
  Branches       5032     5033       +1     
============================================
- Hits          22726    22686      -40     
- Misses        11976    12007      +31     
- Partials       2442     2452      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wForget wForget changed the title [WIP][KYUUBI #6031] Add CollectMetricsPrettyDisplayListener [KYUUBI #6031] Add more details for the CollectMetrics node Feb 1, 2024
@wForget wForget self-assigned this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] Display observation metrics in Spark UI
3 participants