Support to filter sessions/operations with session type #6049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6049 +/- ##
============================================
- Coverage 61.06% 61.00% -0.06%
Complexity 23 23
============================================
Files 623 623
Lines 37168 37179 +11
Branches 5037 5041 +4
============================================
- Hits 22696 22681 -15
- Misses 12020 12039 +19
- Partials 2452 2459 +7 ☔ View full report in Codecov by Sentry. |
cxzl25
approved these changes
Feb 19, 2024
pan3793
approved these changes
Feb 20, 2024
|
can we have test coverage? |
turboFei
added a commit
that referenced
this pull request
Apr 22, 2024
# 🔍 Description Support to filter sessions/operations with session type. ## Issue References 🔗 This pull request fixes # ## Describe Your Solution 🔧 Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6049 from turboFei/batch_interactive. Closes #6049 68390c7 [Wang, Fei] add ut bfc2cb8 [Fei Wang] save c1979c7 [Fei Wang] saev Lead-authored-by: Fei Wang <[email protected]> Co-authored-by: Wang, Fei <[email protected]> Signed-off-by: Wang, Fei <[email protected]> (cherry picked from commit d299da7) Signed-off-by: Wang, Fei <[email protected]>
|
thanks, merged to master and 1.9.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Support to filter sessions/operations with session type.
Issue References 🔗
This pull request fixes #
Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.