-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYUUBI #6084] JDBC driver supports configuration not to pull engine startup logs #6106
base: master
Are you sure you want to change the base?
Conversation
76fd397
to
95dda6a
Compare
is it for security purposes? if so, maybe we should disable the log on the server side? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6106 +/- ##
============================================
+ Coverage 61.12% 62.25% +1.13%
- Complexity 23 24 +1
============================================
Files 623 625 +2
Lines 37200 38982 +1782
Branches 5040 5333 +293
============================================
+ Hits 22738 24269 +1531
- Misses 12001 12245 +244
- Partials 2461 2468 +7 ☔ View full report in Codecov by Sentry. |
We just want to align hive's native beeline behavior and reduce some logs and RPC. |
|
Can we skip the creation of engine-launch-log thread created by |
🔍 Description
Issue References 🔗
This pull request fixes #6084
Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Support
--ignore-launch-engine
option and not pull engine starup logsTypes of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.