[TEST] Set kyuubi.zookeeper.embedded.client.port.address to localhost for testing
#6865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
changed the title
localhost for testing
turboFei
changed the title
localhost for testingkyuubi.zookeeper.embedded.client.port.address to localhost for testing
pan3793
approved these changes
Dec 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6865 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 687 687
Lines 42473 42473
Branches 5796 5796
======================================
Misses 42473 42473 ☔ View full report in Codecov by Sentry. |
|
thanks, merged to main(1.11.0) |
|
seems test failed frequently after merging this PR |
turboFei
added a commit
to turboFei/kyuubi
that referenced
this pull request
Dec 26, 2024
…ient.port.address` to `localhost` for testing" This reverts commit e8cbff3.
turboFei
added a commit
that referenced
this pull request
Dec 26, 2024
…bedded.client.port.address` to `localhost` for testing" This reverts commit e8cbff3. ### Why are the changes needed? ### How was this patch tested? ### Was this patch authored or co-authored using generative AI tooling? Closes #6871 from turboFei/revert_zk. Closes #6871 Closes #6865 1c61f9d [Wang, Fei] Revert "[KYUUBI #6865] [TEST] Set `kyuubi.zookeeper.embedded.client.port.address` to `localhost` for testing" Authored-by: Wang, Fei <[email protected]> Signed-off-by: Wang, Fei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Similar with
kyuubi.frontend.bind.host, it is better to setkyuubi.zookeeper.embedded.client.port.addresstolocalhostfor testing as well.How was this patch tested?
GA.
Was this patch authored or co-authored using generative AI tooling?
No.