[KYUUBI #6864][FOLLOWUP] Support to apply instance with existing labels #6868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
force-pushed
the
instance_label_follow
branch
from
65fac14 to
2a35c70
Compare
turboFei
force-pushed
the
instance_label_follow
branch
from
2a35c70 to
4894784
Compare
pan3793
approved these changes
Dec 26, 2024
pan3793
pushed a commit
that referenced
this pull request
Dec 26, 2024
### Why are the changes needed?
For histogram and timer metrics, it already has label, so need to support apply the instance label with existing ones.
For example:
```
# HELP kyuubi_backend_service_close_operation Generated from Dropwizard metric import (metric=kyuubi.backend_service.close_operation, type=com.codahale.metrics.Timer)
# TYPE kyuubi_backend_service_close_operation summary
kyuubi_backend_service_close_operation{quantile="0.5",}{instance="hadoopkyuubi-1.hadoopkyuubihl.hadoopmaster-dev.svc.140.tess.io:10019"} 0.032923216000000005
```
### How was this patch tested?
UT.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #6868 from turboFei/instance_label_follow.
Closes #6864
4894784 [Wang, Fei] ut
b8f227f [Wang, Fei] save
Authored-by: Wang, Fei <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit fd53913)
Signed-off-by: Cheng Pan <[email protected]>
|
merged to master/1.10 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6868 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 687 687
Lines 42504 42515 +11
Branches 5798 5799 +1
======================================
- Misses 42504 42515 +11 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
For histogram and timer metrics, it already has label, so need to support apply the instance label with existing ones.
For example:
How was this patch tested?
UT.
Was this patch authored or co-authored using generative AI tooling?
No.