Using withOauthTokenProvider instead of withOauthToken to support token refresh #6883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
changed the title
turboFei
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6883 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 688 688
Lines 42551 42552 +1
Branches 5801 5801
======================================
- Misses 42551 42552 +1 ☔ View full report in Codecov by Sentry. |
pan3793
reviewed
Jan 9, 2025
kyuubi-server/src/main/scala/org/apache/kyuubi/util/KubernetesUtils.scala
Show resolved
Hide resolved
4 tasks
pan3793
approved these changes
Jan 14, 2025
pan3793
pushed a commit
that referenced
this pull request
Jan 14, 2025
… to support token refresh ### Why are the changes needed? Address comments: #6877 (reply in thread) > I guess this is a Kyuubi implementation issue, we just read the content from the kyuubi.kubernetes.authenticate.oauthTokenFile and call ConfigBuilder.withOauthToken, I guess this approach does not support token refresh... ### How was this patch tested? Existing GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #6883 from turboFei/k8s_token_provider. Closes #6883 69dd28d [Wang, Fei] comments a01040f [Wang, Fei] withOauthTokenProvider Authored-by: Wang, Fei <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 2617427) Signed-off-by: Cheng Pan <[email protected]>
pan3793
pushed a commit
that referenced
this pull request
Jan 14, 2025
… to support token refresh ### Why are the changes needed? Address comments: #6877 (reply in thread) > I guess this is a Kyuubi implementation issue, we just read the content from the kyuubi.kubernetes.authenticate.oauthTokenFile and call ConfigBuilder.withOauthToken, I guess this approach does not support token refresh... ### How was this patch tested? Existing GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #6883 from turboFei/k8s_token_provider. Closes #6883 69dd28d [Wang, Fei] comments a01040f [Wang, Fei] withOauthTokenProvider Authored-by: Wang, Fei <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 2617427) Signed-off-by: Cheng Pan <[email protected]>
|
thanks, merged to master/1.10.2/1.9.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Address comments: #6877 (reply in thread)
How was this patch tested?
Existing GA.
Was this patch authored or co-authored using generative AI tooling?
No.