-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add year 2023 to Notice files #409
base: trunk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you also need to update the year in flume-ng-clients/flume-ng-log4jappender/src/main/resources-for-jar-with-deps/META-INF/NOTICE
Can someone confirm that project.build.outputTimestamp
in flume-parent/pom
actually gets updated to 2023 for e.g. the generated NOTICE file in jars and the dist archive? Even if it does, do we want to change it to 2023 so that SNAPSHOT builds have a correct year?
…resources-for-jar-with-deps/META-INF/NOTICE'
Thanks for your review.I updated. |
The proper way to change this is to change the copyright line from
to
From a legal perspective, copyright notices aren't required to be present in the files. If they are they should contain the year of creation and may contain years in which substantial modifications were made. But replacing the ending year with "present" eliminates the need to ever change them again. |
NOTICE
Outdated
@@ -1,5 +1,5 @@ | |||
Apache Flume | |||
Copyright 2011-2022 The Apache Software Foundation | |||
Copyright 2011-2023 The Apache Software Foundation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change "2023" to "Present"
@@ -1,5 +1,5 @@ | |||
Flume NG Log4j Appender | |||
Copyright 2009-2022 Apache Software Foundation | |||
Copyright 2009-2023 Apache Software Foundation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
I'm -0 on switching to use "Present". At least my reading of the published ASF policy on NOTICE files requires actual years. text like "present" is ambiguous because it requires that the consumer of the NOTICE file have additional context about when that file was created / modified / distributed. |
@busbey Done, thanks! |
No description provided.