Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add year 2023 to Notice files #409

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

yangjf2019
Copy link
Contributor

No description provided.

@nikita15p
Copy link
Contributor

Looks good to me. Cc @busbey @rgoers can u please approve

Copy link
Contributor

@busbey busbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also need to update the year in flume-ng-clients/flume-ng-log4jappender/src/main/resources-for-jar-with-deps/META-INF/NOTICE

Can someone confirm that project.build.outputTimestamp in flume-parent/pom actually gets updated to 2023 for e.g. the generated NOTICE file in jars and the dist archive? Even if it does, do we want to change it to 2023 so that SNAPSHOT builds have a correct year?

flume-ng-dist/src/main/appended-resources/META-INF/NOTICE Outdated Show resolved Hide resolved
…resources-for-jar-with-deps/META-INF/NOTICE'
@yangjf2019
Copy link
Contributor Author

flume-ng-clients/flume-ng-log4jappender/src/main/resources-for-jar-with-deps/META-INF/NOTICE

Thanks for your review.I updated.

@rgoers
Copy link
Member

rgoers commented Jun 4, 2023

The proper way to change this is to change the copyright line from

Copyright 2011-2022 The Apache Software Foundation

to

Copyright 2011-Present The Apache Software Foundation

From a legal perspective, copyright notices aren't required to be present in the files. If they are they should contain the year of creation and may contain years in which substantial modifications were made. But replacing the ending year with "present" eliminates the need to ever change them again.

NOTICE Outdated
@@ -1,5 +1,5 @@
Apache Flume
Copyright 2011-2022 The Apache Software Foundation
Copyright 2011-2023 The Apache Software Foundation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "2023" to "Present"

@@ -1,5 +1,5 @@
Flume NG Log4j Appender
Copyright 2009-2022 Apache Software Foundation
Copyright 2009-2023 Apache Software Foundation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@busbey
Copy link
Contributor

busbey commented Jun 5, 2023

I'm -0 on switching to use "Present". At least my reading of the published ASF policy on NOTICE files requires actual years.

text like "present" is ambiguous because it requires that the consumer of the NOTICE file have additional context about when that file was created / modified / distributed.

@yangjf2019
Copy link
Contributor Author

@busbey Done, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants