Clean up public non-final statics #14221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following up on apache#14151 and apache#14152, I decided to grep for other non-final public static variables in the Lucene codebase. This change makes statics final where it is both possible and seems appropriate. (That is, the variables really do seem to be constants.)
dweiss
approved these changes
Feb 11, 2025
|
LGTM, thanks! |
risdenk
reviewed
Feb 11, 2025
lucene/analysis/smartcn/src/java/org/apache/lucene/analysis/cn/smart/AnalyzerProfile.java
Outdated
Show resolved
Hide resolved
|
#14216 may help with this specifically |
Also, renamed method to be more descriptive.
risdenk
approved these changes
Feb 12, 2025
Once #14216 and this PR are merged, I'm happy to make the required changes to enable the |
|
Done. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following up on #14151 and #14152, I decided to grep for other
public staticnon-finalvariables in the Lucene codebase.This change makes
staticsfinalwhere it is both possible and seems appropriate. (That is, the variables really do seem to be constants.) I made a coupleprivateinstead, since they are modified, but privately.I also updated some old-school code where IntelliJ flagged opportunities to use newer Java idioms.