Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to fix code completion after new HashMap<> #8237

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Feb 12, 2025

Consider code like:

Map<Object, Object> m = new HashMap<>//code completion here

In VS Code, selecting e.g. the HashMap() option will repeat HashMap here. Inside the NetBeans UI, this will not happen, but <tab> will still insert HashMap.

This is an attempt to avoid these problems, by recording the completion appeared after the <>, and not inserting the name. Not sure if this is the best solution, though.

@lahodaj lahodaj added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests labels Feb 12, 2025
@lahodaj lahodaj added this to the NB26 milestone Feb 12, 2025
@lahodaj lahodaj requested a review from dbalek February 12, 2025 08:19
@mbien
Copy link
Member

mbien commented Feb 12, 2025

quickly checked for regressions since the last completion chaining fix #4165 and everything appeared to still work fine

Copy link
Contributor

@dbalek dbalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants