Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

risc-v/rv-virt: Remove SCANFTEST from rv-virt:citest #15327

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

lupyuen
Copy link
Member

@lupyuen lupyuen commented Dec 24, 2024

Summary

CONFIG_TESTING_SCANFTEST is no longer needed in rv-virt:citest defconfig because of apache/nuttx-apps#2914

This PR excludes CONFIG_TESTING_SCANFTEST from rv-virt:citest so that CI Job risc-v-05 will complete successfully.

Impact

With this PR, CI Job risc-v-05 will complete successfully.

Testing

Before this PR: CI Job risc-v-05 fails at CONFIG_TESTING_SCANFTEST
https://github.com/apache/nuttx/actions/runs/12329209626/job/34829161894?pr=15187#step:7:1268

  Normalize rv-virt/citest
< CONFIG_TESTING_SCANFTEST=y
Changes not staged for commit:
	modified:   boards/risc-v/qemu-rv/rv-virt/configs/citest/defconfig

After this PR: CI Job risc-v-05 completes successfully in Docker:
https://gist.github.com/lupyuen/47ad49c65d12f299451a2dcb7ef90452

sudo docker run \
  -it \
  ghcr.io/apache/nuttx/apache-nuttx-ci-linux:latest \
  /bin/bash
cd
git clone https://github.com/lupyuen2/wip-nuttx nuttx --branch scanftest
git clone https://github.com/apache/nuttx-apps apps
pushd nuttx ; echo NuttX Source: https://github.com/apache/nuttx/tree/$(git rev-parse HEAD) ; popd
pushd apps  ; echo NuttX Apps: https://github.com/apache/nuttx-apps/tree/$(git rev-parse HEAD) ; popd
cd nuttx/tools/ci
./cibuild.sh -c -A -N -R testlist/risc-v-05.dat 

Configuration/Tool: rv-virt/citest
Normalize rv-virt/citest
[no errors]

`CONFIG_TESTING_SCANFTEST` is no longer needed in `rv-virt:citest` defconfig because of apache/nuttx-apps#2914

This PR excludes `CONFIG_TESTING_SCANFTEST` from `rv-virt:citest` so that CI Job `risc-v-05` will complete successfully.
@github-actions github-actions bot added Board: risc-v Size: XS The size of the change in this PR is very small labels Dec 24, 2024
@lupyuen lupyuen marked this pull request as ready for review December 24, 2024 11:31
@xiaoxiang781216 xiaoxiang781216 merged commit 41c0fc0 into apache:master Dec 24, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Board: risc-v Size: XS The size of the change in this PR is very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants