Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(services/s3): Mark xml deserialize error as temporary during list #5178

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Oct 14, 2024

Which issue does this PR close?

None

Rationale for this change

This PR will mark xml deserialize error as temporary during list

// Allow S3 list to retry on XML deserialization errors.
//
// This is because the S3 list API may return incomplete XML data under high load.
// We are confident that our XML decoding logic is correct. When this error occurs,
// we allow retries to obtain the correct data.

Also from: https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListObjectsV2.html

A 200 OK response can contain valid or invalid XML. Make sure to design your application to parse the contents of the response and handle it appropriately.

Copy link
Member

@dqhl76 dqhl76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@Xuanwo
Copy link
Member Author

Xuanwo commented Oct 14, 2024

Thank you @dqhl76 for the quick review!

@Xuanwo Xuanwo merged commit 5dbe6fe into main Oct 14, 2024
93 checks passed
@Xuanwo Xuanwo deleted the allow-retry-on-incomplete-xml branch October 14, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants