refactor(types/operator): rename is_exist to exists #5193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Oct 17, 2024
| @@ -16,7 +16,7 @@ As a side-effect of this design, OpenDAL always return exist for `stat("not_exis | |||
| There are some issues and pull requests related to those issues. | |||
|
|
|||
| - [Invalid metadata for dir objects in s3](https://github.com/apache/opendal/issues/3199) | |||
| - [`is_exist` always return true for key end with '/', in S3 service](https://github.com/apache/opendal/issues/2086) | |||
| - [`exists` always return true for key end with '/', in S3 service](https://github.com/apache/opendal/issues/2086) | |||
There was a problem hiding this comment.
Hi, please don't change existing docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5192.
Rationale for this change
Rename it to
existsfor consistence withstd::fs::existsWhat changes are included in this PR?
Introduces
existsand deprecateis_existincore/types/operatorAre there any user-facing changes?
Yes, it is a breaking change.