Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-1590 Clear open TODO in GenericFactoryTest #633

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

mawiesne
Copy link
Contributor

@mawiesne mawiesne commented Jul 6, 2024

Change

  • adjusts DictionaryFeatureGeneratorFactory to handle situations without a ResourceManager instance at runtime
  • fixes a missing Exception type in catch block of GeneratorFactory#buildGenerator which wasn't handled correctly
  • clears TODO in GeneratorFactoryTest
  • adds another test case to demonstrate that a descriptively declared dictionary is loaded for the creation of a DictionaryFeatureGeneratorFactory
  • adds a related test resource

Tasks

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

@mawiesne mawiesne self-assigned this Jul 6, 2024
- adjusts DictionaryFeatureGeneratorFactory to handle situations without a ResourceManager instance at runtime
- fixes a missing Exception type in catch block of GeneratorFactory#buildGenerator which wasn't handled correctly
- clears TODO in GeneratorFactoryTest
- adds another test case to demonstrate that a descriptively declared dictionary is loaded for the creation of a DictionaryFeatureGeneratorFactory
- adds a related test resource
@mawiesne mawiesne force-pushed the OPENNLP-1590-Clear-open-TODO-in-GenericFactoryTest branch from 09d96bf to 97deeb2 Compare July 6, 2024 18:51
@mawiesne mawiesne requested a review from rzo1 July 6, 2024 18:51
@rzo1 rzo1 merged commit 0b856c5 into main Jul 10, 2024
10 checks passed
@rzo1 rzo1 deleted the OPENNLP-1590-Clear-open-TODO-in-GenericFactoryTest branch July 10, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants