Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-1589 - Fix incorrect array check in CachedFeatureGenerator #635

Closed
wants to merge 7 commits into from

Commits on Jul 4, 2024

  1. OPENNLP-1588 Clean out deprecated code marked for removal

    - removes deprecated getters in several records
    - removes a very long time deprecated constructor of TokenizerME
    - removes deprecated field in DefaultNameContextGenerator and adapts tests accordingly
    - marks a constructor of ADNameSampleStream as "for removal" to indicate actual removal is more likely in upcoming releases
    - marks deprecated 'NameFinderEventStream#generateOutcomes(..)' as "for removal" to indicate actual removal is more likely in upcoming releases
    - clears unused code from NameFinderME
    - fixes resource leak in TokenNameFinderFactory
    mawiesne committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    4188ab0 View commit details
    Browse the repository at this point in the history
  2. OPENNLP-1589 - Implements a more aggressive caching strategy based on…

    … a dual caching strategy; relies on cache evication as implemented by the Cache class of OpenNLP.
    
     - Use Arrays.equals(...)
     - Demonstrate that caching based on identity is broken.
    rzo1 committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    9bac8a7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6123b8c View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Add printing for EvalTest

    rzo1 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    73c2720 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Adjust eval values

    rzo1 committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    360e08d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2458718 View commit details
    Browse the repository at this point in the history
  3. Restore baseline values

    rzo1 committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    5610a22 View commit details
    Browse the repository at this point in the history