[core] Add a http-report action to reporting partition done to remote servers. #4862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzifu666
reviewed
Jan 8, 2025
wwj6591812
reviewed
Jan 9, 2025
...flink-common/src/test/java/org/apache/paimon/flink/action/MarkPartitionDoneActionITCase.java
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/partition/actions/HttpReportMarkDoneAction.java
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/partition/actions/HttpReportMarkDoneAction.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/partition/actions/HttpReportMarkDoneAction.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/partition/actions/HttpReportMarkDoneAction.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/partition/actions/HttpReportMarkDoneAction.java
Show resolved
Hide resolved
LinMingQiang
force-pushed
the
master-feat-http-partition-mark-done
branch
from
3e89d23 to
166ab3e
Compare
|
Thanks to @wwj6591812 @xuzifu666 for review, and all comments has been fixed. |
LinMingQiang
force-pushed
the
master-feat-http-partition-mark-done
branch
3 times, most recently
from
9201a87 to
c678acd
Compare
LinMingQiang
force-pushed
the
master-feat-http-partition-mark-done
branch
from
c678acd to
84069c5
Compare
|
+1 |
JingsongLi
reviewed
Jan 13, 2025
| @Override | ||
| public void markDone(String partition) throws Exception { | ||
| HttpReportMarkDoneResponse response = | ||
| client.post( |
There was a problem hiding this comment.
Maybe it is better to introduce a new client for HttpReportMarkDoneAction?
There was a problem hiding this comment.
Done. I implemented a lightweight httpclient in class HttpReportMarkDoneAction .
LinMingQiang
force-pushed
the
master-feat-http-partition-mark-done
branch
from
4c59d8a to
c410748
Compare
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In order to coordinate the scheduling of real-time data and offline data, we provide an online web service to receive table partition completion information from the real-time application (flink).
When the real-time program completes writing to a partition,
http-reportaction will report the partition to the remote service, when the online service receives the partition done request, it immediately calls the downstream associated offline job.Compared with other actions,
http-reportaction is more time-sensitive and does not require polling or blocking to wait for partitioning to complete. It is passive.Linked issue: close #xxx
Tests
API and Format
Documentation