Proof of concept for advanced glyph layout (2nd try) #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Started with work by Glenn Adams (all bugs are mine): apache#126 Trying to modernize to Java 8 by adding generics, etc. Also early work in integrating with PDAbstractContentStream.
Was forgetting to reset fixupX variable.
Set gdef in GlyphPositioningTable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://github.com/danfickle/pdfbox
See
examples/src/main/java/org/apache/pdfbox/examples/pdmodel/AdvancedTextLayoutSequencesDin91379.java
Glyph layout looks good with NotoSans-Regular. Combinations with two diacritics work after reordering glyphs, using the
patch for FOP-2969 and setting gdef in GlyphPositioningTable.
Output of test is now:
TestDin91379AdvancedLayout-NotoSans-Regular.ttf-20.0.pdf