-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial work on scala 3 support #123
Conversation
pjfanning
commented
May 29, 2023
•
edited
Loading
edited
- add Scala3 support for some of the connectors
- some like the Slick connector are stuck because there is no Scala 3 jar for that dependency
- some more might be fixed if we upgrade to a jar dependency version that supports Scala3 - but I'm wary about upgrading too many dependency versions
- there are quite a few that just don't compile and with some work they could be fixed
- Scala 3 support #126
Update Common.scala Update check-build-test.yml Update Common.scala Update check-build-test.yml implicits more Update check-build-test.yml more issues more more issues Update Serializers.scala amqp Update CassandraSession.scala google settings param issues more google more issues more issues more scalafmt wip implicits Update PravegaReadWriteDocs.scala issue Update TableDataJsonProtocol.scala parens implicits scala3 compile issues more Update KinesisSchedulerSourceSpec.scala more issues disable some scala3 builds disable more scala3 builds Update Dependencies.scala
@mdedetrich I'm going to pause development on this. I think you might be looking at some of the problems already. I think there is some value in not necessarily getting every connector working with scala 3 just yet. Start with the easiest ones and do the others over time. |
@pjfanning It would be ideal to get every connector ready but yes it shouldn't block us. Thankfully we still have time since connector is down the track of our module dependency tree. I think similar to pekko-http, there is probably merit in creating a specific Scala 3 branch as it will be easier for multiple people to work with, wdyt? |
I'm not sure a Scala 3 branch is that useful. I think we should just merge the different PRs to main when they are ready. |
I would disagree here because unless Scala 3 works perfectly fine for all integrations we are going to dirty the For example the immediate problem I have is that while I think merging this is fine (from what I can tell its just doing the obligatory scala source changes just so that Scala 3 compiler can accept it) there are other more complicated changes, i.e. migrating from shapless to its new Scala 3 equivalent. If we have enough of such changes then the argument for creating a Scala 3 branch increases over time because we just end up having a lot of quite non trivial changes just to support Scala 3. In summary having a scala 3 branch allows for more iterative style development which I think is actually preferable for such a project. |
@mdedetrich I created a scala3 branch in the apache project. If you think this is ok as a starting point, could you approve merging this to that branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
merged to scala3 branch |
* try scala 3 (#123) * enable scala3 support for jms connector * refactor * scala 2.12 compile issue * enable elasticsearch Update RestBulkApi.scala sort imports revert merge issue Update CouchbaseFlow.scala
* try scala 3 (#123) * enable scala3 support for jms connector * refactor * scala 2.12 compile issue * enable elasticsearch Update RestBulkApi.scala sort imports revert merge issue Update CouchbaseFlow.scala
* try scala 3 (#123) * enable scala3 support for jms connector * refactor * scala 2.12 compile issue * enable elasticsearch Update RestBulkApi.scala sort imports revert merge issue Update CouchbaseFlow.scala
* try scala 3 (#123) * enable scala3 support for jms connector * refactor * scala 2.12 compile issue * enable elasticsearch Update RestBulkApi.scala sort imports revert merge issue Update CouchbaseFlow.scala
* try scala 3 (apache#123) * enable scala3 support for jms connector * refactor * scala 2.12 compile issue * enable elasticsearch Update RestBulkApi.scala sort imports revert merge issue Update CouchbaseFlow.scala
* try scala 3 (apache#123) * enable scala3 support for jms connector * refactor * scala 2.12 compile issue * enable elasticsearch Update RestBulkApi.scala sort imports revert merge issue Update CouchbaseFlow.scala add scala3 support for s3 Update TestUtils.scala refactor Update Dependencies.scala hex string issue merge issue Update Dependencies.scala more merge issues
* try scala 3 (apache#123) * enable scala3 support for jms connector * refactor * scala 2.12 compile issue * enable elasticsearch Update RestBulkApi.scala sort imports revert merge issue Update CouchbaseFlow.scala add scala3 support for s3 Update TestUtils.scala refactor Update Dependencies.scala hex string issue merge issue Update Dependencies.scala more merge issues Update Formats.scala
* try scala 3 (#123) * enable scala3 support for jms connector * refactor * scala 2.12 compile issue * enable elasticsearch Update RestBulkApi.scala sort imports revert merge issue Update CouchbaseFlow.scala
* try scala 3 (apache#123) * enable scala3 support for jms connector * refactor * scala 2.12 compile issue * enable elasticsearch Update RestBulkApi.scala sort imports revert merge issue Update CouchbaseFlow.scala add scala3 support for s3 Update TestUtils.scala refactor Update Dependencies.scala hex string issue merge issue Update Dependencies.scala more merge issues Update Formats.scala
* try scala 3 (apache#123) * enable scala3 support for jms connector * refactor * scala 2.12 compile issue * enable elasticsearch Update RestBulkApi.scala sort imports revert merge issue Update CouchbaseFlow.scala
* try scala 3 (#123) * enable scala3 support for jms connector * refactor * scala 2.12 compile issue * enable elasticsearch Update RestBulkApi.scala sort imports revert merge issue Update CouchbaseFlow.scala
* try scala 3 (apache#123) * enable scala3 support for jms connector * refactor * scala 2.12 compile issue * enable elasticsearch Update RestBulkApi.scala sort imports revert merge issue Update CouchbaseFlow.scala add scala3 support for s3 Update TestUtils.scala refactor Update Dependencies.scala hex string issue merge issue Update Dependencies.scala more merge issues Update Formats.scala
* try scala 3 (#123) * enable scala3 support for jms connector * refactor * scala 2.12 compile issue * enable elasticsearch Update RestBulkApi.scala sort imports revert merge issue Update CouchbaseFlow.scala
* try scala 3 (#123) * enable scala3 support for jms connector * refactor * scala 2.12 compile issue * enable elasticsearch Update RestBulkApi.scala sort imports revert merge issue Update CouchbaseFlow.scala
* try scala 3 (#123) * enable scala3 support for jms connector * refactor * scala 2.12 compile issue * enable elasticsearch Update RestBulkApi.scala sort imports revert merge issue Update CouchbaseFlow.scala
* try scala 3 (#123) * enable scala3 support for jms connector * refactor * scala 2.12 compile issue * enable elasticsearch Update RestBulkApi.scala sort imports revert merge issue Update CouchbaseFlow.scala
* try scala 3 (apache#123) * enable scala3 support for jms connector * refactor * scala 2.12 compile issue * enable elasticsearch Update RestBulkApi.scala sort imports revert merge issue Update CouchbaseFlow.scala
* try scala 3 (#123) * enable scala3 support for jms connector * refactor * scala 2.12 compile issue * enable elasticsearch Update RestBulkApi.scala sort imports revert merge issue Update CouchbaseFlow.scala
* try scala 3 (#123) * enable scala3 support for jms connector * refactor * scala 2.12 compile issue * enable elasticsearch Update RestBulkApi.scala sort imports revert merge issue Update CouchbaseFlow.scala