Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial work on scala 3 support #123

Merged
merged 1 commit into from
May 30, 2023
Merged

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented May 29, 2023

  • add Scala3 support for some of the connectors
  • some like the Slick connector are stuck because there is no Scala 3 jar for that dependency
  • some more might be fixed if we upgrade to a jar dependency version that supports Scala3 - but I'm wary about upgrading too many dependency versions
  • there are quite a few that just don't compile and with some work they could be fixed
  • Scala 3 support #126

@pjfanning pjfanning marked this pull request as draft May 29, 2023 20:41
@pjfanning pjfanning closed this May 29, 2023
@pjfanning pjfanning reopened this May 29, 2023
Update Common.scala

Update check-build-test.yml

Update Common.scala

Update check-build-test.yml

implicits

more

Update check-build-test.yml

more issues

more

more issues

Update Serializers.scala

amqp

Update CassandraSession.scala

google settings

param issues

more google

more issues

more issues

more

scalafmt

wip

implicits

Update PravegaReadWriteDocs.scala

issue

Update TableDataJsonProtocol.scala

parens

implicits

scala3 compile issues

more

Update KinesisSchedulerSourceSpec.scala

more issues

disable some scala3 builds

disable more scala3 builds

Update Dependencies.scala
@pjfanning
Copy link
Contributor Author

@mdedetrich I'm going to pause development on this.

I think you might be looking at some of the problems already.

I think there is some value in not necessarily getting every connector working with scala 3 just yet. Start with the easiest ones and do the others over time.

@mdedetrich
Copy link
Contributor

@pjfanning It would be ideal to get every connector ready but yes it shouldn't block us. Thankfully we still have time since connector is down the track of our module dependency tree.

I think similar to pekko-http, there is probably merit in creating a specific Scala 3 branch as it will be easier for multiple people to work with, wdyt?

@pjfanning
Copy link
Contributor Author

I'm not sure a Scala 3 branch is that useful. I think we should just merge the different PRs to main when they are ready.

@mdedetrich
Copy link
Contributor

mdedetrich commented May 30, 2023

I'm not sure a Scala 3 branch is that useful. I think we should just merge the different PRs to main when they are ready.

I would disagree here because unless Scala 3 works perfectly fine for all integrations we are going to dirty the main branch which can cause issues later down the track if have to do modifications to Pekko connectors. iirc This is actually the same reason why the scala 3 support was in a separate branch for both akka-http and pekko-http, its because integrating Scala 3 support for the projects in question was complicated and long winding and due to the large amount of integrations I think this project passes that bar.

For example the immediate problem I have is that while I think merging this is fine (from what I can tell its just doing the obligatory scala source changes just so that Scala 3 compiler can accept it) there are other more complicated changes, i.e. migrating from shapless to its new Scala 3 equivalent. If we have enough of such changes then the argument for creating a Scala 3 branch increases over time because we just end up having a lot of quite non trivial changes just to support Scala 3.

In summary having a scala 3 branch allows for more iterative style development which I think is actually preferable for such a project.

@pjfanning pjfanning changed the title [DRAFT] try scala 3 initial work on scala 3 support May 30, 2023
@pjfanning pjfanning changed the base branch from main to scala3 May 30, 2023 12:04
@pjfanning pjfanning marked this pull request as ready for review May 30, 2023 12:04
@pjfanning
Copy link
Contributor Author

@mdedetrich I created a scala3 branch in the apache project. If you think this is ok as a starting point, could you approve merging this to that branch?

@pjfanning pjfanning requested a review from mdedetrich May 30, 2023 12:05
@pjfanning pjfanning mentioned this pull request May 30, 2023
Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning
Copy link
Contributor Author

merged to scala3 branch

@pjfanning pjfanning merged commit 49c8faa into apache:scala3 May 30, 2023
@pjfanning pjfanning deleted the scala3 branch May 30, 2023 13:44
pjfanning added a commit that referenced this pull request May 30, 2023
pjfanning added a commit that referenced this pull request May 31, 2023
pjfanning added a commit that referenced this pull request Jun 7, 2023
pjfanning added a commit that referenced this pull request Jun 8, 2023
pjfanning added a commit that referenced this pull request Jun 8, 2023
pjfanning added a commit to pjfanning/incubator-pekko-connectors that referenced this pull request Jun 8, 2023
pjfanning added a commit that referenced this pull request Jun 9, 2023
pjfanning added a commit to pjfanning/incubator-pekko-connectors that referenced this pull request Jun 9, 2023
pjfanning added a commit that referenced this pull request Jun 10, 2023
* try scala 3 (#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala
pjfanning added a commit that referenced this pull request Jun 10, 2023
pjfanning added a commit that referenced this pull request Jun 10, 2023
* try scala 3 (#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala
pjfanning added a commit that referenced this pull request Jun 26, 2023
pjfanning added a commit that referenced this pull request Jun 26, 2023
* try scala 3 (#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala
pjfanning added a commit that referenced this pull request Jun 26, 2023
pjfanning added a commit that referenced this pull request Jun 26, 2023
* try scala 3 (#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala
pjfanning added a commit to pjfanning/incubator-pekko-connectors that referenced this pull request Jun 26, 2023
* try scala 3 (apache#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala
pjfanning added a commit to pjfanning/incubator-pekko-connectors that referenced this pull request Jun 26, 2023
* try scala 3 (apache#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala

add scala3 support for s3

Update TestUtils.scala

refactor

Update Dependencies.scala

hex string issue

merge issue

Update Dependencies.scala

more merge issues
pjfanning added a commit to pjfanning/incubator-pekko-connectors that referenced this pull request Jun 26, 2023
* try scala 3 (apache#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala

add scala3 support for s3

Update TestUtils.scala

refactor

Update Dependencies.scala

hex string issue

merge issue

Update Dependencies.scala

more merge issues

Update Formats.scala
pjfanning added a commit that referenced this pull request Jun 27, 2023
pjfanning added a commit that referenced this pull request Jun 27, 2023
* try scala 3 (#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala
pjfanning added a commit to pjfanning/incubator-pekko-connectors that referenced this pull request Jun 27, 2023
* try scala 3 (apache#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala

add scala3 support for s3

Update TestUtils.scala

refactor

Update Dependencies.scala

hex string issue

merge issue

Update Dependencies.scala

more merge issues

Update Formats.scala
mdedetrich pushed a commit to mdedetrich/pekko-connectors that referenced this pull request Jul 3, 2023
mdedetrich pushed a commit to mdedetrich/pekko-connectors that referenced this pull request Jul 3, 2023
* try scala 3 (apache#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala
pjfanning added a commit that referenced this pull request Jul 14, 2023
pjfanning added a commit that referenced this pull request Jul 14, 2023
* try scala 3 (#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala
pjfanning added a commit to pjfanning/incubator-pekko-connectors that referenced this pull request Jul 14, 2023
* try scala 3 (apache#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala

add scala3 support for s3

Update TestUtils.scala

refactor

Update Dependencies.scala

hex string issue

merge issue

Update Dependencies.scala

more merge issues

Update Formats.scala
pjfanning added a commit that referenced this pull request Aug 3, 2023
pjfanning added a commit that referenced this pull request Aug 3, 2023
* try scala 3 (#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala
pjfanning added a commit that referenced this pull request Aug 6, 2023
pjfanning added a commit that referenced this pull request Aug 6, 2023
* try scala 3 (#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala
pjfanning added a commit that referenced this pull request Aug 6, 2023
pjfanning added a commit that referenced this pull request Aug 6, 2023
* try scala 3 (#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala
pjfanning added a commit that referenced this pull request Aug 11, 2023
pjfanning added a commit that referenced this pull request Aug 11, 2023
* try scala 3 (#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala
mdedetrich pushed a commit to mdedetrich/pekko-connectors that referenced this pull request Aug 15, 2023
mdedetrich pushed a commit to mdedetrich/pekko-connectors that referenced this pull request Aug 15, 2023
* try scala 3 (apache#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala
pjfanning added a commit that referenced this pull request Aug 17, 2023
pjfanning added a commit that referenced this pull request Aug 17, 2023
* try scala 3 (#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala
pjfanning added a commit that referenced this pull request Aug 19, 2023
pjfanning added a commit that referenced this pull request Aug 19, 2023
* try scala 3 (#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants