Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala3 couchbase support #128

Merged
merged 5 commits into from
May 30, 2023
Merged

Scala3 couchbase support #128

merged 5 commits into from
May 30, 2023

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented May 30, 2023 •
edited
Loading

  • I've worked through a couple of compile issues
  • play-json (a test dependency) doesn't have a full release that supports Scala 3 and furthermore, the 2.10.0 RCs only support Java 11.
  • it was easy to test with jackson instead
  • this PR is targeted at the 'scala3' branch

#126

@pjfanning pjfanning marked this pull request as draft May 30, 2023 15:02
@pjfanning pjfanning marked this pull request as ready for review May 30, 2023 19:14
mdedetrich
mdedetrich approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 1ba975e into apache:scala3 May 30, 2023
@pjfanning pjfanning deleted the scala3-couchbase branch May 30, 2023 19:55
pjfanning added a commit that referenced this pull request May 30, 2023
@pjfanning
Scala3 couchbase support (#128)
403e0c6 
* initial work on scala3 support for couchbase

* Update model.scala

* Update CouchbaseFlow.scala

* use jackson in test code instead of play-json

* Update Dependencies.scala
pjfanning added a commit that referenced this pull request May 31, 2023
@pjfanning
Scala3 couchbase support (#128)
0faf8e1 
* initial work on scala3 support for couchbase

* Update model.scala

* Update CouchbaseFlow.scala

* use jackson in test code instead of play-json

* Update Dependencies.scala
pjfanning added a commit that referenced this pull request Jun 7, 2023
@pjfanning
Scala3 couchbase support (#128)
47ceff6 
* initial work on scala3 support for couchbase

* Update model.scala

* Update CouchbaseFlow.scala

* use jackson in test code instead of play-json

* Update Dependencies.scala
pjfanning added a commit that referenced this pull request Jun 8, 2023
@pjfanning
Scala3 couchbase support (#128)
732a73c 
* initial work on scala3 support for couchbase

* Update model.scala

* Update CouchbaseFlow.scala

* use jackson in test code instead of play-json

* Update Dependencies.scala
pjfanning added a commit that referenced this pull request Jun 8, 2023
@pjfanning
Scala3 couchbase support (#128)
40b4df5 
* initial work on scala3 support for couchbase

* Update model.scala

* Update CouchbaseFlow.scala

* use jackson in test code instead of play-json

* Update Dependencies.scala
pjfanning added a commit that referenced this pull request Jun 9, 2023
@pjfanning
Scala3 couchbase support (#128)
5d46fad 
* initial work on scala3 support for couchbase

* Update model.scala

* Update CouchbaseFlow.scala

* use jackson in test code instead of play-json

* Update Dependencies.scala
pjfanning added a commit that referenced this pull request Jun 10, 2023
@pjfanning
Scala3 couchbase support (#128)
3429f90 
* initial work on scala3 support for couchbase

* Update model.scala

* Update CouchbaseFlow.scala

* use jackson in test code instead of play-json

* Update Dependencies.scala
pjfanning added a commit that referenced this pull request Jun 10, 2023
@pjfanning
Scala3 couchbase support (#128)
16c2202 
* initial work on scala3 support for couchbase

* Update model.scala

* Update CouchbaseFlow.scala

* use jackson in test code instead of play-json

* Update Dependencies.scala
pjfanning added a commit that referenced this pull request Jun 26, 2023
@pjfanning
Scala3 couchbase support (#128)
758d226 
* initial work on scala3 support for couchbase

* Update model.scala

* Update CouchbaseFlow.scala

* use jackson in test code instead of play-json

* Update Dependencies.scala
pjfanning added a commit that referenced this pull request Jun 26, 2023
@pjfanning
Scala3 couchbase support (#128)
4e267c9 
* initial work on scala3 support for couchbase

* Update model.scala

* Update CouchbaseFlow.scala

* use jackson in test code instead of play-json

* Update Dependencies.scala
pjfanning added a commit that referenced this pull request Jun 27, 2023
@pjfanning
Scala3 couchbase support (#128)
f26e159 
* initial work on scala3 support for couchbase

* Update model.scala

* Update CouchbaseFlow.scala

* use jackson in test code instead of play-json

* Update Dependencies.scala
mdedetrich pushed a commit to mdedetrich/pekko-connectors that referenced this pull request Jul 3, 2023
@pjfanning @mdedetrich
Scala3 couchbase support (apache#128)
426d4ba 
* initial work on scala3 support for couchbase

* Update model.scala

* Update CouchbaseFlow.scala

* use jackson in test code instead of play-json

* Update Dependencies.scala
pjfanning added a commit that referenced this pull request Jul 14, 2023
@pjfanning
Scala3 couchbase support (#128)
ad8ea71 
* initial work on scala3 support for couchbase

* Update model.scala

* Update CouchbaseFlow.scala

* use jackson in test code instead of play-json

* Update Dependencies.scala
pjfanning added a commit that referenced this pull request Aug 3, 2023
@pjfanning
Scala3 couchbase support (#128)
55320dc 
* initial work on scala3 support for couchbase

* Update model.scala

* Update CouchbaseFlow.scala

* use jackson in test code instead of play-json

* Update Dependencies.scala
pjfanning added a commit that referenced this pull request Aug 6, 2023
@pjfanning
Scala3 couchbase support (#128)
7186c8d 
* initial work on scala3 support for couchbase

* Update model.scala

* Update CouchbaseFlow.scala

* use jackson in test code instead of play-json

* Update Dependencies.scala
pjfanning added a commit that referenced this pull request Aug 6, 2023
@pjfanning
Scala3 couchbase support (#128)
cbbd756 
* initial work on scala3 support for couchbase

* Update model.scala

* Update CouchbaseFlow.scala

* use jackson in test code instead of play-json

* Update Dependencies.scala
pjfanning added a commit that referenced this pull request Aug 11, 2023
@pjfanning
Scala3 couchbase support (#128)
3ed7abd 
* initial work on scala3 support for couchbase

* Update model.scala

* Update CouchbaseFlow.scala

* use jackson in test code instead of play-json

* Update Dependencies.scala
mdedetrich pushed a commit to mdedetrich/pekko-connectors that referenced this pull request Aug 15, 2023
@pjfanning @mdedetrich
Scala3 couchbase support (apache#128)
23b99f6 
* initial work on scala3 support for couchbase

* Update model.scala

* Update CouchbaseFlow.scala

* use jackson in test code instead of play-json

* Update Dependencies.scala
pjfanning added a commit that referenced this pull request Aug 17, 2023
@pjfanning
Scala3 couchbase support (#128)
650c13b 
* initial work on scala3 support for couchbase

* Update model.scala

* Update CouchbaseFlow.scala

* use jackson in test code instead of play-json

* Update Dependencies.scala
pjfanning added a commit that referenced this pull request Aug 19, 2023
@pjfanning
Scala3 couchbase support (#128)
f23710a 
* initial work on scala3 support for couchbase

* Update model.scala

* Update CouchbaseFlow.scala

* use jackson in test code instead of play-json

* Update Dependencies.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdedetrich mdedetrich mdedetrich approved these changes

@He-Pin He-Pin Awaiting requested review from He-Pin

@nvollmar nvollmar Awaiting requested review from nvollmar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjfanning @mdedetrich