Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala3 support for more google connectors #143

Merged
merged 11 commits into from
Jun 8, 2023
Merged

Scala3 support for more google connectors #143

merged 11 commits into from
Jun 8, 2023

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Jun 8, 2023 •
edited
Loading

@pjfanning pjfanning changed the title [DRAFT] Scala3 support for more google connectors Scala3 support for more google connectors Jun 8, 2023
@mdedetrich
Copy link
Contributor

mdedetrich commented Jun 8, 2023 •
edited
Loading

Is .toStringan alias for compactString. Also the Anyref with JsonFormat[T] seems a bit suspicious, does it work with just JsonFormat[T]?

@pjfanning
Copy link
Contributor Author

Is .toStringan alias for compactString. Also the Anyref with JsonFormat[T] seems a bit suspicious, does it work with just JsonFormat[T]?

toString is an alias for compactString. The toString caused issues in some tests where the generated classes in the tests overrode the toString.

mdedetrich
mdedetrich approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 585cacb into apache:scala3 Jun 8, 2023
@pjfanning pjfanning deleted the scala3-google-extra branch June 8, 2023 21:00
pjfanning added a commit that referenced this pull request Jun 8, 2023
@pjfanning
Scala3 support for more google connectors (#143)
c54ee93 
* support scala3 (google-common)

* support scala3 on more google connectors

* continue

* imports

* more implicit issues

* Update BigQueryCollectionFormats.scala

* further issues

* class access issues

* Update BigQueryRestBasicFormats.scala

* use compactPrint because toString causes tests to fail in Scala3

* review issue
pjfanning added a commit that referenced this pull request Jun 9, 2023
@pjfanning
Scala3 support for more google connectors (#143)
fa497e8 
* support scala3 (google-common)

* support scala3 on more google connectors

* continue

* imports

* more implicit issues

* Update BigQueryCollectionFormats.scala

* further issues

* class access issues

* Update BigQueryRestBasicFormats.scala

* use compactPrint because toString causes tests to fail in Scala3

* review issue
pjfanning added a commit that referenced this pull request Jun 10, 2023
@pjfanning
Scala3 support for more google connectors (#143)
08e8e97 
* support scala3 (google-common)

* support scala3 on more google connectors

* continue

* imports

* more implicit issues

* Update BigQueryCollectionFormats.scala

* further issues

* class access issues

* Update BigQueryRestBasicFormats.scala

* use compactPrint because toString causes tests to fail in Scala3

* review issue
pjfanning added a commit that referenced this pull request Jun 10, 2023
@pjfanning
Scala3 support for more google connectors (#143)
7cae1f6 
* support scala3 (google-common)

* support scala3 on more google connectors

* continue

* imports

* more implicit issues

* Update BigQueryCollectionFormats.scala

* further issues

* class access issues

* Update BigQueryRestBasicFormats.scala

* use compactPrint because toString causes tests to fail in Scala3

* review issue
pjfanning added a commit that referenced this pull request Jun 26, 2023
@pjfanning
Scala3 support for more google connectors (#143)
17022b8 
* support scala3 (google-common)

* support scala3 on more google connectors

* continue

* imports

* more implicit issues

* Update BigQueryCollectionFormats.scala

* further issues

* class access issues

* Update BigQueryRestBasicFormats.scala

* use compactPrint because toString causes tests to fail in Scala3

* review issue
pjfanning added a commit that referenced this pull request Jun 26, 2023
@pjfanning
Scala3 support for more google connectors (#143)
a2d1a1b 
* support scala3 (google-common)

* support scala3 on more google connectors

* continue

* imports

* more implicit issues

* Update BigQueryCollectionFormats.scala

* further issues

* class access issues

* Update BigQueryRestBasicFormats.scala

* use compactPrint because toString causes tests to fail in Scala3

* review issue
pjfanning added a commit that referenced this pull request Jun 27, 2023
@pjfanning
Scala3 support for more google connectors (#143)
3f57d6a 
* support scala3 (google-common)

* support scala3 on more google connectors

* continue

* imports

* more implicit issues

* Update BigQueryCollectionFormats.scala

* further issues

* class access issues

* Update BigQueryRestBasicFormats.scala

* use compactPrint because toString causes tests to fail in Scala3

* review issue
mdedetrich pushed a commit to mdedetrich/pekko-connectors that referenced this pull request Jul 3, 2023
@pjfanning @mdedetrich
Scala3 support for more google connectors (apache#143)
a1807cd 
* support scala3 (google-common)

* support scala3 on more google connectors

* continue

* imports

* more implicit issues

* Update BigQueryCollectionFormats.scala

* further issues

* class access issues

* Update BigQueryRestBasicFormats.scala

* use compactPrint because toString causes tests to fail in Scala3

* review issue
pjfanning added a commit that referenced this pull request Jul 14, 2023
@pjfanning
Scala3 support for more google connectors (#143)
af81ec6 
* support scala3 (google-common)

* support scala3 on more google connectors

* continue

* imports

* more implicit issues

* Update BigQueryCollectionFormats.scala

* further issues

* class access issues

* Update BigQueryRestBasicFormats.scala

* use compactPrint because toString causes tests to fail in Scala3

* review issue
pjfanning added a commit that referenced this pull request Aug 3, 2023
@pjfanning
Scala3 support for more google connectors (#143)
08af6cd 
* support scala3 (google-common)

* support scala3 on more google connectors

* continue

* imports

* more implicit issues

* Update BigQueryCollectionFormats.scala

* further issues

* class access issues

* Update BigQueryRestBasicFormats.scala

* use compactPrint because toString causes tests to fail in Scala3

* review issue
pjfanning added a commit that referenced this pull request Aug 6, 2023
@pjfanning
Scala3 support for more google connectors (#143)
945fd74 
* support scala3 (google-common)

* support scala3 on more google connectors

* continue

* imports

* more implicit issues

* Update BigQueryCollectionFormats.scala

* further issues

* class access issues

* Update BigQueryRestBasicFormats.scala

* use compactPrint because toString causes tests to fail in Scala3

* review issue
pjfanning added a commit that referenced this pull request Aug 6, 2023
@pjfanning
Scala3 support for more google connectors (#143)
cc17880 
* support scala3 (google-common)

* support scala3 on more google connectors

* continue

* imports

* more implicit issues

* Update BigQueryCollectionFormats.scala

* further issues

* class access issues

* Update BigQueryRestBasicFormats.scala

* use compactPrint because toString causes tests to fail in Scala3

* review issue
pjfanning added a commit that referenced this pull request Aug 11, 2023
@pjfanning
Scala3 support for more google connectors (#143)
097241e 
* support scala3 (google-common)

* support scala3 on more google connectors

* continue

* imports

* more implicit issues

* Update BigQueryCollectionFormats.scala

* further issues

* class access issues

* Update BigQueryRestBasicFormats.scala

* use compactPrint because toString causes tests to fail in Scala3

* review issue
pjfanning added a commit that referenced this pull request Aug 17, 2023
@pjfanning
Scala3 support for more google connectors (#143)
19c34a2 
* support scala3 (google-common)

* support scala3 on more google connectors

* continue

* imports

* more implicit issues

* Update BigQueryCollectionFormats.scala

* further issues

* class access issues

* Update BigQueryRestBasicFormats.scala

* use compactPrint because toString causes tests to fail in Scala3

* review issue
pjfanning added a commit that referenced this pull request Aug 19, 2023
@pjfanning
Scala3 support for more google connectors (#143)
e0202ad 
* support scala3 (google-common)

* support scala3 on more google connectors

* continue

* imports

* more implicit issues

* Update BigQueryCollectionFormats.scala

* further issues

* class access issues

* Update BigQueryRestBasicFormats.scala

* use compactPrint because toString causes tests to fail in Scala3

* review issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdedetrich mdedetrich mdedetrich approved these changes

@He-Pin He-Pin Awaiting requested review from He-Pin

@nvollmar nvollmar Awaiting requested review from nvollmar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjfanning @mdedetrich