New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala3 support for jms connector #145

Merged

pjfanning merged 5 commits into apache:scala3 from pjfanning:scala3-jms

Jun 10, 2023

Contributor

pjfanning commented Jun 8, 2023 •

edited

Loading

Part of #126

Scala 3 compile issues needed fixing.

main ones were related to using protected methods on self types
also some issues where fields were ambiguous (multiple inheritance in Scala means that a field can be declared on 2 separate traits)

I introduced a GraphStageCompanion trait to give public access to the methods that were needed to get Scala3 compile to work.

pjfanning force-pushed the scala3-jms branch from 61bd52c to 32736b4 Compare

June 8, 2023 21:09

pjfanning changed the title ~~[DRAFT] Scala3 support for jms connector~~ Scala3 support for jms connector

pjfanning requested review from mdedetrich, He-Pin and nvollmar

June 8, 2023 22:43

pjfanning force-pushed the scala3 branch from 585cacb to c54ee93 Compare

June 8, 2023 23:00

pjfanning force-pushed the scala3-jms branch 2 times, most recently from 3079935 to 530736d Compare

June 8, 2023 23:10

mdedetrich requested changes

View reviewed changes

Contributor

mdedetrich left a comment

Some more cases of Any

jms/src/main/scala/org/apache/pekko/stream/connectors/jms/impl/GraphStageCompanion.scala


		def graphStageDestination: Destination

		def scheduleOnceOnGraphStage(timerKey: Any, delay: FiniteDuration): Unit

Contributor

mdedetrich Jun 9, 2023

Can we avoid using Any here?

Contributor Author

pjfanning Jun 9, 2023

This signature is taken from the function I am delegating to.

Contributor Author

pjfanning Jun 9, 2023

@mdedetrich is this answer ok? The timerKey can be any case class, the 'Any' type is actually what makes sense. This is also an internal class, not an API one.

Contributor

mdedetrich Jun 10, 2023

Let me check this now, we really shouldn't have Any like this so something fishy is going on.

pjfanning force-pushed the scala3 branch from bb2dbdb to 6fe18f5 Compare

June 9, 2023 11:49

pjfanning added 5 commits

June 9, 2023 12:50


          try scala 3 (apache#123)

6d7dc4d


          enable scala3 support for jms connector

2f02a1a


          refactor

3e80fca


          scala 2.12 compile issue

2fb40a7


          enable elasticsearch

b123181

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala

pjfanning force-pushed the scala3-jms branch from 530736d to b123181 Compare

June 9, 2023 11:50

mdedetrich approved these changes

View reviewed changes

Contributor

mdedetrich left a comment

Okay I had a deeper look and you are right, it also uses Any with the current version (i.e. scheduleOnce). This probably should be looked into but its not relevant to Scala 3

mdedetrich approved these changes

View reviewed changes

Contributor

mdedetrich left a comment

lgtm

pjfanning merged commit 8674ff5 into apache:scala3

pjfanning deleted the scala3-jms branch

June 10, 2023 10:05

pjfanning added a commit that referenced this pull request


          Scala3 support for jms connector (#145)

63f224f

* try scala 3 (#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala

pjfanning added a commit that referenced this pull request


          Scala3 support for jms connector (#145)

99beaaf

* try scala 3 (#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala

pjfanning added a commit that referenced this pull request


          Scala3 support for jms connector (#145)

c64c909

* try scala 3 (#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala

pjfanning added a commit that referenced this pull request


          Scala3 support for jms connector (#145)

38419a8

* try scala 3 (#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala

pjfanning added a commit to pjfanning/incubator-pekko-connectors that referenced this pull request


          Scala3 support for jms connector (apache#145)

cae12d3

* try scala 3 (apache#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala

pjfanning added a commit to pjfanning/incubator-pekko-connectors that referenced this pull request


          Scala3 support for jms connector (apache#145)

042fda8

* try scala 3 (apache#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala

add scala3 support for s3

Update TestUtils.scala

refactor

Update Dependencies.scala

hex string issue

merge issue

Update Dependencies.scala

more merge issues

pjfanning added a commit to pjfanning/incubator-pekko-connectors that referenced this pull request


          Scala3 support for jms connector (apache#145)

ce74d69

* try scala 3 (apache#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala

add scala3 support for s3

Update TestUtils.scala

refactor

Update Dependencies.scala

hex string issue

merge issue

Update Dependencies.scala

more merge issues

Update Formats.scala

pjfanning added a commit that referenced this pull request


          Scala3 support for jms connector (#145)

3424cce

* try scala 3 (#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala

pjfanning added a commit to pjfanning/incubator-pekko-connectors that referenced this pull request


          Scala3 support for jms connector (apache#145)

6cf0bfc

* try scala 3 (apache#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala

add scala3 support for s3

Update TestUtils.scala

refactor

Update Dependencies.scala

hex string issue

merge issue

Update Dependencies.scala

more merge issues

Update Formats.scala

mdedetrich pushed a commit to mdedetrich/pekko-connectors that referenced this pull request


          Scala3 support for jms connector (apache#145)

b1123a9

* try scala 3 (apache#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala

pjfanning added a commit that referenced this pull request


          Scala3 support for jms connector (#145)

c250977

* try scala 3 (#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala

pjfanning added a commit to pjfanning/incubator-pekko-connectors that referenced this pull request


          Scala3 support for jms connector (apache#145)

73a90d6

* try scala 3 (apache#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala

add scala3 support for s3

Update TestUtils.scala

refactor

Update Dependencies.scala

hex string issue

merge issue

Update Dependencies.scala

more merge issues

Update Formats.scala

pjfanning added a commit that referenced this pull request


          Scala3 support for jms connector (#145)

29c3e62

* try scala 3 (#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala

pjfanning added a commit that referenced this pull request


          Scala3 support for jms connector (#145)

248fa2f

* try scala 3 (#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala

pjfanning added a commit that referenced this pull request


          Scala3 support for jms connector (#145)

4a82738

* try scala 3 (#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala

pjfanning added a commit that referenced this pull request


          Scala3 support for jms connector (#145)

f33feb7

* try scala 3 (#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala

mdedetrich pushed a commit to mdedetrich/pekko-connectors that referenced this pull request


          Scala3 support for jms connector (apache#145)

eade9ee

* try scala 3 (apache#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala

pjfanning added a commit that referenced this pull request


          Scala3 support for jms connector (#145)

777e5b3

* try scala 3 (#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala

pjfanning added a commit that referenced this pull request


          Scala3 support for jms connector (#145)

a579671

* try scala 3 (#123)

* enable scala3 support for jms connector

* refactor

* scala 2.12 compile issue

* enable elasticsearch

Update RestBulkApi.scala

sort imports

revert merge issue

Update CouchbaseFlow.scala

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet