support scala3 in avroparquet #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add some scala3 tests Update AvroParquetSinkSpec.scala Update avroparquet.md Update AbstractAvroParquet.scala Update AbstractAvroParquet.scala
|
@mdedetrich @He-Pin @nvollmar would any of you time to review this? It is the final easy Scala3 transition. The other harder ones have issues raised for them - https://github.com/apache/incubator-pekko-connectors/issues?q=is%3Aissue+is%3Aopen+label%3Ascala3 |
He-Pin
reviewed
Jun 12, 2023
project/Dependencies.scala
Outdated
| @@ -167,13 +167,16 @@ object Dependencies { | |||
| "com.google.jimfs" % "jimfs" % "1.2" % Test // ApacheV2 | |||
| )) | |||
|
|
|||
| val avro4sVersion: Def.Initialize[String] = Def.setting { | |||
| if (scalaVersion.value.startsWith("2")) "4.1.1" else "5.0.4" | |||
He-Pin
reviewed
Jun 12, 2023
| val folder: String = "./" + Random.alphanumeric.take(8).mkString("") | ||
|
|
||
| val genFinalFile: Gen[String] = for { | ||
| fileName <- Gen.alphaLowerStr | ||
| } yield { folder + "/" + fileName + ".parquet" } | ||
| } yield { | ||
| folder + "/" + fileName + ".parquet" |
There was a problem hiding this comment.
this code was just moved around - I did not rewrite it - I just need to have the code set up so some code can be different in Scala 2 and Scala 3
it would be bad imo for me to start rewriting working code in a PR that is about purely Scala3 support
if we want to rewrite working code that we don't like, we really need new PRs
There was a problem hiding this comment.
I'm not sure how the code got reformatted. Possibly my IDE - possibly scalafmt. If this is an issue I can try to change the formatting of this line back.
mdedetrich
reviewed
Jun 12, 2023
mdedetrich
reviewed
Jun 12, 2023
pjfanning
added a commit
that referenced
this pull request
Jun 26, 2023
* support scala3 in avroparquet add some scala3 tests Update AvroParquetSinkSpec.scala Update avroparquet.md Update AbstractAvroParquet.scala Update AbstractAvroParquet.scala * refactor test code * Update AbstractAvroParquetBase.scala * fix doc links * use Common.isScala3 * Update Dependencies.scala * Update build.sbt
pjfanning
added a commit
that referenced
this pull request
Jun 26, 2023
* support scala3 in avroparquet add some scala3 tests Update AvroParquetSinkSpec.scala Update avroparquet.md Update AbstractAvroParquet.scala Update AbstractAvroParquet.scala * refactor test code * Update AbstractAvroParquetBase.scala * fix doc links * use Common.isScala3 * Update Dependencies.scala * Update build.sbt
pjfanning
added a commit
that referenced
this pull request
Jun 27, 2023
* support scala3 in avroparquet add some scala3 tests Update AvroParquetSinkSpec.scala Update avroparquet.md Update AbstractAvroParquet.scala Update AbstractAvroParquet.scala * refactor test code * Update AbstractAvroParquetBase.scala * fix doc links * use Common.isScala3 * Update Dependencies.scala * Update build.sbt
pjfanning
added a commit
that referenced
this pull request
Jul 14, 2023
* support scala3 in avroparquet add some scala3 tests Update AvroParquetSinkSpec.scala Update avroparquet.md Update AbstractAvroParquet.scala Update AbstractAvroParquet.scala * refactor test code * Update AbstractAvroParquetBase.scala * fix doc links * use Common.isScala3 * Update Dependencies.scala * Update build.sbt
pjfanning
added a commit
that referenced
this pull request
Aug 3, 2023
* support scala3 in avroparquet add some scala3 tests Update AvroParquetSinkSpec.scala Update avroparquet.md Update AbstractAvroParquet.scala Update AbstractAvroParquet.scala * refactor test code * Update AbstractAvroParquetBase.scala * fix doc links * use Common.isScala3 * Update Dependencies.scala * Update build.sbt
pjfanning
added a commit
that referenced
this pull request
Aug 6, 2023
* support scala3 in avroparquet add some scala3 tests Update AvroParquetSinkSpec.scala Update avroparquet.md Update AbstractAvroParquet.scala Update AbstractAvroParquet.scala * refactor test code * Update AbstractAvroParquetBase.scala * fix doc links * use Common.isScala3 * Update Dependencies.scala * Update build.sbt
pjfanning
added a commit
that referenced
this pull request
Aug 6, 2023
* support scala3 in avroparquet add some scala3 tests Update AvroParquetSinkSpec.scala Update avroparquet.md Update AbstractAvroParquet.scala Update AbstractAvroParquet.scala * refactor test code * Update AbstractAvroParquetBase.scala * fix doc links * use Common.isScala3 * Update Dependencies.scala * Update build.sbt
pjfanning
added a commit
that referenced
this pull request
Aug 11, 2023
* support scala3 in avroparquet add some scala3 tests Update AvroParquetSinkSpec.scala Update avroparquet.md Update AbstractAvroParquet.scala Update AbstractAvroParquet.scala * refactor test code * Update AbstractAvroParquetBase.scala * fix doc links * use Common.isScala3 * Update Dependencies.scala * Update build.sbt
mdedetrich
pushed a commit
to mdedetrich/pekko-connectors
that referenced
this pull request
Aug 15, 2023
* support scala3 in avroparquet add some scala3 tests Update AvroParquetSinkSpec.scala Update avroparquet.md Update AbstractAvroParquet.scala Update AbstractAvroParquet.scala * refactor test code * Update AbstractAvroParquetBase.scala * fix doc links * use Common.isScala3 * Update Dependencies.scala * Update build.sbt
pjfanning
added a commit
that referenced
this pull request
Aug 17, 2023
* support scala3 in avroparquet add some scala3 tests Update AvroParquetSinkSpec.scala Update avroparquet.md Update AbstractAvroParquet.scala Update AbstractAvroParquet.scala * refactor test code * Update AbstractAvroParquetBase.scala * fix doc links * use Common.isScala3 * Update Dependencies.scala * Update build.sbt
pjfanning
added a commit
that referenced
this pull request
Aug 19, 2023
* support scala3 in avroparquet add some scala3 tests Update AvroParquetSinkSpec.scala Update avroparquet.md Update AbstractAvroParquet.scala Update AbstractAvroParquet.scala * refactor test code * Update AbstractAvroParquetBase.scala * fix doc links * use Common.isScala3 * Update Dependencies.scala * Update build.sbt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #126