Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala3 mqtt streaming #161

Merged
merged 6 commits into from
Jun 10, 2023
Merged

Scala3 mqtt streaming #161

merged 6 commits into from
Jun 10, 2023

Conversation

pjfanning
Copy link
Contributor

part of #126

The main problems

  • Scala 3 is stricter about private fields/functions - some tests are in docs.scaladsl and somehow Scala 2 lets that have access to private fields - Scala 3 cares about this - I had to make some stuff public and mark them as @InternalApi
  • MqttFlowSpec had to be changed. Scala 3 does not allow access to some stuff on self types - including implicits
    • since it is test code and it was easy to get rid of the self type, that seemed the easiest solution (I had tried a number of other ways without success)

He-Pin
He-Pin reviewed Jun 10, 2023
View reviewed changes
mqtt-streaming/src/main/scala/org/apache/pekko/stream/connectors/mqtt/streaming/model.scala
@@ -53,7 +53,8 @@ object ControlPacketType {
val DISCONNECT = ControlPacketType(14)
val Reserved2 = ControlPacketType(15)
}
final case class ControlPacketType private (underlying: Int) extends AnyVal
@InternalApi
final case class ControlPacketType(underlying: Int) extends AnyVal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private[connectors] ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code is used in a test that is in the docs.scaladsl package - so the private[connectors] is invisible to that package

He-Pin
He-Pin approved these changes Jun 10, 2023
View reviewed changes
Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@He-Pin He-Pin merged commit fb3aa2b into apache:scala3 Jun 10, 2023
@pjfanning pjfanning deleted the scala3-mqtt-streaming branch June 10, 2023 12:50
pjfanning added a commit that referenced this pull request Jun 10, 2023
@pjfanning
support scala3 in mqtt-streaming (#161)
e84730b 
Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

remove val declarations
pjfanning added a commit that referenced this pull request Jun 10, 2023
@pjfanning
support scala3 in mqtt-streaming (#161)
9cce753 
Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

remove val declarations
pjfanning added a commit that referenced this pull request Jun 10, 2023
@pjfanning
support scala3 in mqtt-streaming (#161)
9e9cd19 
Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

remove val declarations
pjfanning added a commit that referenced this pull request Jun 26, 2023
@pjfanning
support scala3 in mqtt-streaming (#161)
e858209 
Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

remove val declarations
pjfanning added a commit that referenced this pull request Jun 26, 2023
@pjfanning
support scala3 in mqtt-streaming (#161)
36770bb 
Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

remove val declarations
pjfanning added a commit that referenced this pull request Jun 27, 2023
@pjfanning
support scala3 in mqtt-streaming (#161)
def6662 
Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

remove val declarations
mdedetrich pushed a commit to mdedetrich/pekko-connectors that referenced this pull request Jul 3, 2023
@pjfanning @mdedetrich
support scala3 in mqtt-streaming (apache#161)
96ca4f6 
Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

remove val declarations
pjfanning added a commit that referenced this pull request Jul 14, 2023
@pjfanning
support scala3 in mqtt-streaming (#161)
382ffd0 
Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

remove val declarations
pjfanning added a commit that referenced this pull request Aug 3, 2023
@pjfanning
support scala3 in mqtt-streaming (#161)
c6bb1e7 
Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

remove val declarations
pjfanning added a commit that referenced this pull request Aug 6, 2023
@pjfanning
support scala3 in mqtt-streaming (#161)
b915f4a 
Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

remove val declarations
pjfanning added a commit that referenced this pull request Aug 6, 2023
@pjfanning
support scala3 in mqtt-streaming (#161)
a278c40 
Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

remove val declarations
pjfanning added a commit that referenced this pull request Aug 11, 2023
@pjfanning
support scala3 in mqtt-streaming (#161)
5ac4fe7 
Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

remove val declarations
mdedetrich pushed a commit to mdedetrich/pekko-connectors that referenced this pull request Aug 15, 2023
@pjfanning @mdedetrich
support scala3 in mqtt-streaming (apache#161)
b4fbe34 
Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

remove val declarations
pjfanning added a commit that referenced this pull request Aug 17, 2023
@pjfanning
support scala3 in mqtt-streaming (#161)
3a8be3e 
Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

remove val declarations
pjfanning added a commit that referenced this pull request Aug 19, 2023
@pjfanning
support scala3 in mqtt-streaming (#161)
c22f80d 
Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

Update MqttFlowSpec.scala

remove val declarations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@He-Pin He-Pin He-Pin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjfanning @He-Pin