enable scala3 build for more google connectors #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
reviewed
Jun 11, 2023
.../scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/javadsl/GooglePubSub.scala
Outdated
Show resolved
Hide resolved
mdedetrich
reviewed
Jun 11, 2023
.../scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/javadsl/GooglePubSub.scala
Show resolved
Hide resolved
pjfanning
added a commit
that referenced
this pull request
Jun 26, 2023
* enable scala3 build for more google connectors * implicits * disable part of scala3 build * try full build again * Update GooglePubSub.scala * refactor suggested by @mdedetrich * remove interim variables * add comments * Update GooglePubSub.scala
pjfanning
added a commit
that referenced
this pull request
Jun 26, 2023
* enable scala3 build for more google connectors * implicits * disable part of scala3 build * try full build again * Update GooglePubSub.scala * refactor suggested by @mdedetrich * remove interim variables * add comments * Update GooglePubSub.scala
pjfanning
added a commit
that referenced
this pull request
Jun 27, 2023
* enable scala3 build for more google connectors * implicits * disable part of scala3 build * try full build again * Update GooglePubSub.scala * refactor suggested by @mdedetrich * remove interim variables * add comments * Update GooglePubSub.scala
pjfanning
added a commit
that referenced
this pull request
Jul 14, 2023
* enable scala3 build for more google connectors * implicits * disable part of scala3 build * try full build again * Update GooglePubSub.scala * refactor suggested by @mdedetrich * remove interim variables * add comments * Update GooglePubSub.scala
pjfanning
added a commit
that referenced
this pull request
Aug 3, 2023
* enable scala3 build for more google connectors * implicits * disable part of scala3 build * try full build again * Update GooglePubSub.scala * refactor suggested by @mdedetrich * remove interim variables * add comments * Update GooglePubSub.scala
pjfanning
added a commit
that referenced
this pull request
Aug 6, 2023
* enable scala3 build for more google connectors * implicits * disable part of scala3 build * try full build again * Update GooglePubSub.scala * refactor suggested by @mdedetrich * remove interim variables * add comments * Update GooglePubSub.scala
pjfanning
added a commit
that referenced
this pull request
Aug 6, 2023
* enable scala3 build for more google connectors * implicits * disable part of scala3 build * try full build again * Update GooglePubSub.scala * refactor suggested by @mdedetrich * remove interim variables * add comments * Update GooglePubSub.scala
pjfanning
added a commit
that referenced
this pull request
Aug 11, 2023
* enable scala3 build for more google connectors * implicits * disable part of scala3 build * try full build again * Update GooglePubSub.scala * refactor suggested by @mdedetrich * remove interim variables * add comments * Update GooglePubSub.scala
mdedetrich
pushed a commit
to mdedetrich/pekko-connectors
that referenced
this pull request
Aug 15, 2023
* enable scala3 build for more google connectors * implicits * disable part of scala3 build * try full build again * Update GooglePubSub.scala * refactor suggested by @mdedetrich * remove interim variables * add comments * Update GooglePubSub.scala
pjfanning
added a commit
that referenced
this pull request
Aug 17, 2023
* enable scala3 build for more google connectors * implicits * disable part of scala3 build * try full build again * Update GooglePubSub.scala * refactor suggested by @mdedetrich * remove interim variables * add comments * Update GooglePubSub.scala
pjfanning
added a commit
that referenced
this pull request
Aug 19, 2023
* enable scala3 build for more google connectors * implicits * disable part of scala3 build * try full build again * Update GooglePubSub.scala * refactor suggested by @mdedetrich * remove interim variables * add comments * Update GooglePubSub.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #126