Scala3 ftp support #170
Merged
Scala3 ftp support #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
requested changes
Jun 11, 2023
| @@ -573,6 +573,6 @@ object Sftp extends SftpApi { | |||
| */ | |||
| def create(customSshClient: SSHClient): SftpApi = | |||
| new SftpApi { | |||
| override val sshClient: SSHClient = customSshClient | |||
There was a problem hiding this comment.
Why is this a def now? This could have a performance impact because it would get evaluated each time
There was a problem hiding this comment.
- more scala3 compiler issues
- the super class has
def sshClient(): SSHClient - the
()seem to be the reason that the override can't make it aval customSshClientis a constant as far as the anonymous classnew SftpApi {is concerned- so there will be no recalculation on each call to
def sshClient(): SSHClient - one option would be to make it
final def sshClient(): SSHClient-- but with anonymous classes, you would assume everything is implied to be final anyway
- so there will be no recalculation on each call to
There was a problem hiding this comment.
Okay all good then, approving
pjfanning
added a commit
that referenced
this pull request
Jun 26, 2023
* support scala3 in ftp connector * Update BaseSpec.scala
pjfanning
added a commit
that referenced
this pull request
Jun 26, 2023
* support scala3 in ftp connector * Update BaseSpec.scala
pjfanning
added a commit
that referenced
this pull request
Jun 27, 2023
* support scala3 in ftp connector * Update BaseSpec.scala
pjfanning
added a commit
that referenced
this pull request
Jul 14, 2023
* support scala3 in ftp connector * Update BaseSpec.scala
pjfanning
added a commit
that referenced
this pull request
Aug 3, 2023
* support scala3 in ftp connector * Update BaseSpec.scala
pjfanning
added a commit
that referenced
this pull request
Aug 6, 2023
* support scala3 in ftp connector * Update BaseSpec.scala
pjfanning
added a commit
that referenced
this pull request
Aug 6, 2023
* support scala3 in ftp connector * Update BaseSpec.scala
pjfanning
added a commit
that referenced
this pull request
Aug 11, 2023
* support scala3 in ftp connector * Update BaseSpec.scala
mdedetrich
pushed a commit
to mdedetrich/pekko-connectors
that referenced
this pull request
Aug 15, 2023
* support scala3 in ftp connector * Update BaseSpec.scala
pjfanning
added a commit
that referenced
this pull request
Aug 17, 2023
* support scala3 in ftp connector * Update BaseSpec.scala
pjfanning
added a commit
that referenced
this pull request
Aug 19, 2023
* support scala3 in ftp connector * Update BaseSpec.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #126