Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable -Werror check on Java 21 #713

Closed
wants to merge 1 commit into from
Closed

disable -Werror check on Java 21 #713

wants to merge 1 commit into from

Conversation

pjfanning
Copy link
Contributor

see #296

@raboof raboof mentioned this pull request Jul 1, 2024
Merged
raboof
raboof approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A shame, I'm not opposed to the change but perhaps we can reduce the scope to just the file component like #714?

@pjfanning
Copy link
Contributor Author

close in favour of #714

@pjfanning pjfanning closed this Jul 1, 2024
@pjfanning pjfanning deleted the disable-werror branch July 3, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjfanning @raboof