Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove compatibility test #229

Closed
wants to merge 1 commit into from

Conversation

pjfanning
Copy link
Contributor

this test blocks #222 and it isn't a core feature

#228 is about writing a new test to replace this

@raboof
Copy link
Member

raboof commented Feb 12, 2024

Looking at protocolbuffers/protobuf-javascript#127 (comment) are we sure it's impossible to make this work with newer versions of protobuf?

@pjfanning
Copy link
Contributor Author

@raboof to flip the question - is it worth blocking the upgrade of the grpc and protobuf libs until someone works out how to fix this test? #228 is there to remind us that we need to add this or an equivalent test back.

@raboof
Copy link
Member

raboof commented Feb 12, 2024

#228 is there to remind us that we need to add this or an equivalent test back.

TBH I'm not optimistic that that would actually happen when there's no pressing need anymore ;)

@raboof to flip the question - is it worth blocking the upgrade of the grpc and protobuf libs until someone works out how to fix this test?

It seems we are fairly close... let's give it a week?

@raboof
Copy link
Member

raboof commented Feb 20, 2024

superseded by #222

@raboof raboof closed this Feb 20, 2024
@pjfanning pjfanning deleted the remove-compat-test branch February 20, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants