use ByteString.toArrayUnsafe #308
Conversation
| finally gzos.close() | ||
| ByteString.fromArrayUnsafe(baos.toByteArray) | ||
| } | ||
|
|
||
| override def uncompress(compressed: ByteString): ByteString = { | ||
| val gzis = new GZIPInputStream(new ByteArrayInputStream(compressed.toArray)) | ||
| val gzis = new GZIPInputStream(new ByteArrayInputStream(compressed.toArrayUnsafe())) |
There was a problem hiding this comment.
could we have used compressed.asInputStream? because toArrayUnsafe can still create a new array in case the byteString is a rope.
There was a problem hiding this comment.
Makes sense. We need to use MethodHandles to still support Pekko 1.0 (asInputStream is only in Pekko 1.1).
Something like https://github.com/apache/pekko-http/pull/539/files (this was reverted because of a bug in the hpack code - twitter/hpack#43).
There was a problem hiding this comment.
We need to use MethodHandles to still support Pekko 1.0 (asInputStream is only in Pekko 1.1).
thats unfortunate
this was reverted because of a bug in the hpack code - twitter/hpack#43
last commit of that library was 5 years ago. also it seems to be deprecated
There was a problem hiding this comment.
May be we can the netty 's Hpack？
There was a problem hiding this comment.
We need to use MethodHandles to still support Pekko 1.0 (asInputStream is only in Pekko 1.1).
IMHO we could just require Pekko 1.1 in Pekko gRPC 1.1
avoids array copying