Fix invalid memory access on the first pending batch receive callback #441
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
pulsar-client-cpp/lib/ConsumerImplBase.cc
Lines 109 to 112 in 5940cb5
In the code above,
batchReceive
is a reference to the first element in the queue (batchPendingReceives_
). Afterpop()
, the memory would be invalid to access, which might cause unexpected crash.Modifications
Add a
popBatchReceiveCallback
method that moves the callback from the first element inbatchPendingReceives_
. Use this method to replace error-pronefront()
-pop()
calls.