Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Keep compatible with old boost versions #444

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

erobot
Copy link
Contributor

@erobot erobot commented Sep 5, 2024

Motivation

Keep compatible with old boost versions.

Modifications

Port boost compatible code from branch-3.4 and make minor changes for USE_ASIO.

Code from branch-3.4:

#if BOOST_VERSION >= 107000
strand_(boost::asio::make_strand(executor_->getIOService().get_executor())),
#elif BOOST_VERSION >= 106600
strand_(executor_->getIOService().get_executor()),
#else
strand_(executor_->getIOService()),
#endif

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    No functionality changed. Just keep the old compatible behavior.

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

Copy link
Contributor

@BewareMyPower BewareMyPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay to keep compatibility with old boost versions. But the pre-built libraries and dependency files (vcpkg.json or dependencies.yaml) all uses new boost or asio versions. So the compatibility is not guaranteed in future.

@BewareMyPower BewareMyPower merged commit 1a6c7ce into apache:main Sep 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants