Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support the namespace offloadThresholdInSeconds API in pulsaradmin pkg #1271

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

ericsyh
Copy link
Contributor

@ericsyh ericsyh commented Aug 26, 2024

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

pulsaradmin/pkg/admin/namespace.go Outdated Show resolved Hide resolved
pulsaradmin/pkg/admin/namespace.go Outdated Show resolved Hide resolved
Copy link
Member

@RobertIndie RobertIndie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help add the unit test for it?

@ericsyh
Copy link
Contributor Author

ericsyh commented Aug 26, 2024

Okay, I will add test for new funcs.

Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
@crossoverJie crossoverJie added this to the v0.14.0 milestone Aug 27, 2024
@crossoverJie crossoverJie merged commit 953d9ea into apache:master Aug 27, 2024
7 checks passed
@ericsyh ericsyh deleted the support-offload-by-time branch September 5, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants