-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[branch-2.10] [fix] [broker] Fix isolated group not work problem. #21098
Merged
codelipenghui
merged 12 commits into
apache:branch-2.10
from
horizonzy:branch-2.10-fix-isolated-group-not-work
Sep 6, 2023
Merged
[branch-2.10] [fix] [broker] Fix isolated group not work problem. #21098
codelipenghui
merged 12 commits into
apache:branch-2.10
from
horizonzy:branch-2.10-fix-isolated-group-not-work
Sep 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horizonzy
changed the title
Fix isolated group not work problem.
[branch-2.10] [fix] [broker] Fix isolated group not work problem.
Aug 30, 2023
hangc0276
reviewed
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test to protect the logic
.../main/java/org/apache/pulsar/bookie/rackawareness/IsolatedBookieEnsemblePlacementPolicy.java
Outdated
Show resolved
Hide resolved
hangc0276
requested review from
merlimat,
codelipenghui,
zymap,
poorbarcode and
mattisonchao
August 30, 2023 23:46
hangc0276
added
type/bug
The PR fixed a bug or issue reported a bug
ready-to-test
labels
Aug 30, 2023
hangc0276
approved these changes
Sep 5, 2023
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Sep 5, 2023
poorbarcode
approved these changes
Sep 5, 2023
/pulsarbot run-failure-checks |
1 similar comment
/pulsarbot run-failure-checks |
Please wait for this PR to fix some tests. |
/pulsarbot run-failure-checks |
Hi, @horizonzy You should rebase your branch to branch-2.10 |
horizonzy
force-pushed
the
branch-2.10-fix-isolated-group-not-work
branch
from
September 6, 2023 02:33
28a7150
to
cc8f08a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-2.10
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/2.10.6
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a cherry-pick commit for #21096.
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: