-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][misc] Add proper nslookup (included in bind-tools) to docker image #22878
[fix][misc] Add proper nslookup (included in bind-tools) to docker image #22878
Conversation
- the default nslookup is based on busybox and it isn't compatible with Kubernetes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume bind-utils
is light-weight.
It is. The downside is that it could contain vulnerabilities which show up in scanning. However there doesn't seem to be an alternative for backwards compatibility with Pulsar helm charts that use nslookup to check when another component is available. |
The correct package name in Alpine is |
After we do the |
Pulsar cluster gets initialized properly with Apache Pulsar Helm chart when using nslookup from bind-tools package. Here's the way I tested: https://github.com/lhotari/pulsar-helm-chart/pull/10/files#diff-f34da55ca08f1a30591d8b0b3e885bcc678537b2a9a4aadea4f190806b374ddcR3 . Pushed the image to https://hub.docker.com/r/lhotari/pulsar-all/tags ( |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22878 +/- ##
============================================
- Coverage 73.57% 73.29% -0.28%
- Complexity 32624 32702 +78
============================================
Files 1877 1889 +12
Lines 139502 141885 +2383
Branches 15299 15565 +266
============================================
+ Hits 102638 103997 +1359
- Misses 28908 29877 +969
- Partials 7956 8011 +55
Flags with carried forward coverage won't be shown. Click here to find out more. |
Fixes: #22877
Motivation
The default
nslookup
in Alpine is based on busybox and it isn't compatible with Kubernetes. See #22877 for more details.Modifications
Install
bind-tools
package to get propernslookup
Documentation
doc
doc-required
doc-not-needed
doc-complete