Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][misc] Add proper nslookup (included in bind-tools) to docker image #22878

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Jun 7, 2024

Fixes: #22877

Motivation

The default nslookup in Alpine is based on busybox and it isn't compatible with Kubernetes. See #22877 for more details.

Modifications

Install bind-tools package to get proper nslookup

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

- the default nslookup is based on busybox and it isn't compatible with Kubernetes
@lhotari lhotari added this to the 3.4.0 milestone Jun 7, 2024
@lhotari lhotari self-assigned this Jun 7, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 7, 2024
Copy link
Contributor

@heesung-sn heesung-sn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume bind-utils is light-weight.

@lhotari
Copy link
Member Author

lhotari commented Jun 7, 2024

I assume bind-utils is light-weight.

It is. The downside is that it could contain vulnerabilities which show up in scanning. However there doesn't seem to be an alternative for backwards compatibility with Pulsar helm charts that use nslookup to check when another component is available.

@lhotari lhotari changed the title [fix][misc] Add proper nslookup (included in bind-utils) to docker image [fix][misc] Add proper nslookup (included in bind-tools) to docker image Jun 7, 2024
@lhotari
Copy link
Member Author

lhotari commented Jun 7, 2024

The correct package name in Alpine is bind-tools. Testing it soon with Apache Pulsar Helm chart.

@merlimat
Copy link
Contributor

merlimat commented Jun 7, 2024

I assume bind-utils is light-weight.

It is. The downside is that it could contain vulnerabilities which show up in scanning. However there doesn't seem to be an alternative for backwards compatibility with Pulsar helm charts that use nslookup to check when another component is available.

After we do the RUN apk upgrade --no-cache step, it's picking up the latest version, with no vulnerabilities

@lhotari
Copy link
Member Author

lhotari commented Jun 7, 2024

Pulsar cluster gets initialized properly with Apache Pulsar Helm chart when using nslookup from bind-tools package. Here's the way I tested: https://github.com/lhotari/pulsar-helm-chart/pull/10/files#diff-f34da55ca08f1a30591d8b0b3e885bcc678537b2a9a4aadea4f190806b374ddcR3 . Pushed the image to https://hub.docker.com/r/lhotari/pulsar-all/tags (docker pull lhotari/pulsar-all:3.3.0-nslookup)

@lhotari lhotari closed this Jun 7, 2024
@lhotari lhotari reopened this Jun 7, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.29%. Comparing base (bbc6224) to head (9147edf).
Report is 363 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22878      +/-   ##
============================================
- Coverage     73.57%   73.29%   -0.28%     
- Complexity    32624    32702      +78     
============================================
  Files          1877     1889      +12     
  Lines        139502   141885    +2383     
  Branches      15299    15565     +266     
============================================
+ Hits         102638   103997    +1359     
- Misses        28908    29877     +969     
- Partials       7956     8011      +55     
Flag Coverage Δ
inttests 27.20% <ø> (+2.62%) ⬆️
systests 24.70% <ø> (+0.37%) ⬆️
unittests 72.33% <ø> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 392 files with indirect coverage changes

@lhotari lhotari merged commit e236f49 into apache:master Jun 7, 2024
55 checks passed
lhotari added a commit that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] nslookup in apachepulsar/pulsar:3.3.0 isn't compatible with kubernetes search domains
4 participants